github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2628] [MERGED] fix: URI-encode magic link callbackURL #12657

New Issue
Closed
opened 2026-04-13 08:31:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:31:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2628
Author: @philipp-lampert
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @Bekacru

Base: main ← Head: fix/encode-magiclink-callbackURL

📝 Commits (9)

📊 Changes

1 file changed (+18 additions, -7 deletions)

View changed files

📝 packages/better-auth/src/plugins/magic-link/index.ts (+18 -7)

📄 Description

Fix: URI-encode magic link callbackURL

Fixes an issue preventing magic link authentication from correctly redirecting to a callbackURL with query parameters. This is crucial for restoring post-login redirection to specific states.

Closes #2592

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2628 **Author:** [@philipp-lampert](https://github.com/philipp-lampert) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/encode-magiclink-callbackURL` --- ### 📝 Commits (9) - [`f1aecc1`](https://github.com/better-auth/better-auth/commit/f1aecc184a209978e6dc1a1ba5c17e0d2239aa39) fix: encode/decode magic link callbackURL - [`db71eed`](https://github.com/better-auth/better-auth/commit/db71eeddda058eb691911293c3109e8332fe63cb) lint - [`0dc99c0`](https://github.com/better-auth/better-auth/commit/0dc99c08732cd6446799b545c9af54ad63209ca9) lint - [`7deade6`](https://github.com/better-auth/better-auth/commit/7deade68dbe2f578ec21b753fd402c2adc1844c3) Improve code safety - [`ca61a9b`](https://github.com/better-auth/better-auth/commit/ca61a9b256725bd1c802c8c8a4021075661193a1) Remove unnecessary changes - [`b568d1f`](https://github.com/better-auth/better-auth/commit/b568d1f172c4999688279fac136f4de8d4943b42) Remove redundant safety checks - [`47c7cd1`](https://github.com/better-auth/better-auth/commit/47c7cd13ae52ba967e7a7360759ea95c830d1ace) Remove redundant function - [`087b57f`](https://github.com/better-auth/better-auth/commit/087b57f5e84815d3f71d970cd116b7d424665ade) Remove unnecessary safety checks - [`fca7f29`](https://github.com/better-auth/better-auth/commit/fca7f29ff15d379c690de160df37fb819c220a49) lint ### 📊 Changes **1 file changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/magic-link/index.ts` (+18 -7) </details> ### 📄 Description ### Fix: URI-encode magic link `callbackURL` Fixes an issue preventing **magic link** authentication from correctly redirecting to a **callbackURL** with **query parameters**. This is crucial for restoring post-login redirection to specific states. Closes #2592 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:31:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#12657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?