github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Github provider fails when you don't include email #1263

New Issue
Closed
opened 2026-03-13 08:30:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 08:30:27 -05:00
Owner
Copy Link

Originally created by @mwufi on GitHub (May 24, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

If you created a Github app, and don't manually select email scope, you get an error upon signing in!

Image

Fix

To prevent this, we can educate users to add the email scope to their Github app (before copying the client id/secret)

Note that this only applies to Github apps! (https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/differences-between-github-apps-and-oauth-apps)

Oauth apps are fine and work by default.

Current vs. Expected behavior

Current: fails
Expected: Does not fail (after user fix)

What version of Better Auth are you using?

1.2.8

Provide environment information

- OS: Mac OS
- Browser: Chrome

Which area(s) are affected? (Select all that apply)

Backend, Documentation

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

No response

Originally created by @mwufi on GitHub (May 24, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce If you created a Github app, and don't manually select email scope, you get an error upon signing in! <img width="837" alt="Image" src="https://github.com/user-attachments/assets/f7db0fa7-8277-4710-adcd-e146dba837a4" /> ## Fix To prevent this, we can educate users to add the email scope to their Github app (before copying the client id/secret) Note that this only applies to Github apps! (https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/differences-between-github-apps-and-oauth-apps) Oauth apps are fine and work by default. ### Current vs. Expected behavior Current: fails Expected: Does not fail (after user fix) ### What version of Better Auth are you using? 1.2.8 ### Provide environment information ```bash - OS: Mac OS - Browser: Chrome ``` ### Which area(s) are affected? (Select all that apply) Backend, Documentation ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context _No response_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#1263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?