github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1351] [MERGED] 🐛 Fix Google IdToken Auth #12018

New Issue
Closed
opened 2026-04-13 08:07:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:07:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1351
Author: @abegehr
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @Bekacru

Base: main ← Head: abegehr/fix-google-id-token-auth

📝 Commits (1)

  • e1fbc07 🐛 Fix Google IdToken Auth

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/social-providers/google.ts (+2 -1)

📄 Description

"The value of iss in the ID token is equal to accounts.google.com or https://accounts.google.com."

Source: https://developers.google.com/identity/gsi/web/guides/verify-google-id-token

I ran into this when trying to auth via idToken obtained from auth within a Chrome Extension. According to the Google doc above the iss can also be "accounts.google.com", which was the case for the idToken I got.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1351 **Author:** [@abegehr](https://github.com/abegehr) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `abegehr/fix-google-id-token-auth` --- ### 📝 Commits (1) - [`e1fbc07`](https://github.com/better-auth/better-auth/commit/e1fbc07767eb50f12556646f51641069f0198dee) 🐛 Fix Google IdToken Auth ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/social-providers/google.ts` (+2 -1) </details> ### 📄 Description "The value of iss in the ID token is equal to accounts.google.com or https://accounts.google.com." Source: https://developers.google.com/identity/gsi/web/guides/verify-google-id-token I ran into this when trying to auth via idToken obtained from auth within a Chrome Extension. According to the Google doc above the iss can also be "accounts.google.com", which was the case for the idToken I got. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:07:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#12018
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?