github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-31 12:32:52 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1299] [CLOSED] update(adapter-tests): added skip options & added more tests #11986

New Issue
Closed
opened 2026-04-13 08:06:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:06:34 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1299
Author: @ping-maxwell
Created: 1/29/2025
Status: ❌ Closed

Base: main ← Head: adapter/tests

📝 Commits (8)

  • 0a16159 add(adapter-tests): should find many with offset and limit
  • f597a3b add: skip options to all adapter tests
  • 2542914 add: create with select test
  • 312e99c Merge branch 'main' into adapter/tests
  • 4227db8 fix: skip generate id test for mongo adpater
  • b2c362c fix: kysely adapter tests to skip generate ID
  • e3764e2 fix: tests failing
  • c4bc11d chore: format

📊 Changes

3 files changed (+384 additions, -309 deletions)

View changed files

📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysley.test.ts (+3 -1)
📝 packages/better-auth/src/adapters/mongodb-adapter/adapter.mongo-db.test.ts (+3 -1)
📝 packages/better-auth/src/adapters/test.ts (+378 -307)

📄 Description

  • skippable option to all tests
  • add "should find many with offset and limit" test
  • add "create with select" test - to test if the adapter's create method honors the select param.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1299 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 1/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `adapter/tests` --- ### 📝 Commits (8) - [`0a16159`](https://github.com/better-auth/better-auth/commit/0a161599c667eb0215652a0525cf71b3b03cb2e9) add(adapter-tests): should find many with offset and limit - [`f597a3b`](https://github.com/better-auth/better-auth/commit/f597a3b206a83a322f36ac7f4919b5a3af94dd03) add: skip options to all adapter tests - [`2542914`](https://github.com/better-auth/better-auth/commit/2542914aa70062b1c597e6fd929489d72a290ae3) add: create with select test - [`312e99c`](https://github.com/better-auth/better-auth/commit/312e99c5ef1c648447fec31acb10a2e136a4a073) Merge branch 'main' into adapter/tests - [`4227db8`](https://github.com/better-auth/better-auth/commit/4227db836db0741dd776df938732b668b70c608e) fix: skip generate id test for mongo adpater - [`b2c362c`](https://github.com/better-auth/better-auth/commit/b2c362c902320117c443413b0962a2d916fece97) fix: kysely adapter tests to skip generate ID - [`e3764e2`](https://github.com/better-auth/better-auth/commit/e3764e2da73863c470ab9eb34578368e20585348) fix: tests failing - [`c4bc11d`](https://github.com/better-auth/better-auth/commit/c4bc11df4d234cf7cbf030be4fd54c9b2c775f84) chore: format ### 📊 Changes **3 files changed** (+384 additions, -309 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysley.test.ts` (+3 -1) 📝 `packages/better-auth/src/adapters/mongodb-adapter/adapter.mongo-db.test.ts` (+3 -1) 📝 `packages/better-auth/src/adapters/test.ts` (+378 -307) </details> ### 📄 Description * skippable option to all tests * add "should find many with offset and limit" test * add "create with select" test - to test if the adapter's create method honors the `select` param. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:06:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11986