github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-10-18 11:32:15 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #985] [CLOSED] feat: Add account parameter to custom password verifier #11821

New Issue
Closed
opened 2026-04-13 08:01:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:01:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/985
Author: @kzlar
Created: 12/21/2024
Status: ❌ Closed

Base: main ← Head: feat/verify-with-account

📝 Commits (1)

  • 1366ada feat: Add account parameter to custom password verifier

📊 Changes

6 files changed (+9 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/api/routes/sign-in.ts (+1 -0)
📝 packages/better-auth/src/api/routes/update-user.ts (+2 -0)
📝 packages/better-auth/src/init.ts (+2 -1)
📝 packages/better-auth/src/plugins/phone-number/index.ts (+1 -0)
📝 packages/better-auth/src/plugins/username/index.ts (+1 -0)
📝 packages/better-auth/src/utils/password.ts (+2 -0)

📄 Description

Hi,

Following some discussion on discord (https://discord.com/channels/1288403910284935179/1288403910284935182/1320099161659674725) I figured I'd take a stab at adding an account parameter to the custom password verifier.
In short, this helps in implementing external authentication, similar to what is provided by authjs (https://next-auth.js.org/configuration/providers/credentials).
I'd say this is probably not something most people should use, but given that the API already exists, I think this PR makes it more useful without adding more risks.

Opened this as Draft to collect feedback and also because for some reason the build fails on my setup (but in my defense the main branch also fails so perhaps its a local issue)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/985 **Author:** [@kzlar](https://github.com/kzlar) **Created:** 12/21/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/verify-with-account` --- ### 📝 Commits (1) - [`1366ada`](https://github.com/better-auth/better-auth/commit/1366ada9625387ae0db0d85ce319eb803c69b412) feat: Add account parameter to custom password verifier ### 📊 Changes **6 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/sign-in.ts` (+1 -0) 📝 `packages/better-auth/src/api/routes/update-user.ts` (+2 -0) 📝 `packages/better-auth/src/init.ts` (+2 -1) 📝 `packages/better-auth/src/plugins/phone-number/index.ts` (+1 -0) 📝 `packages/better-auth/src/plugins/username/index.ts` (+1 -0) 📝 `packages/better-auth/src/utils/password.ts` (+2 -0) </details> ### 📄 Description Hi, Following some discussion on discord (https://discord.com/channels/1288403910284935179/1288403910284935182/1320099161659674725) I figured I'd take a stab at adding an `account` parameter to the custom password verifier. In short, this helps in implementing external authentication, similar to what is provided by authjs (https://next-auth.js.org/configuration/providers/credentials). I'd say this is probably not something most people should use, but given that the API already exists, I think this PR makes it more useful without adding more risks. Opened this as Draft to collect feedback and also because for some reason the build fails on my setup (but in my defense the main branch also fails so perhaps its a local issue) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:01:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11821