github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Reset Password URL doesn't pass multiple query params #1170

New Issue
Closed
opened 2026-03-13 08:26:22 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-03-13 08:26:22 -05:00
Owner
Copy Link

Originally created by @isnifer on GitHub (May 6, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. Call forgetPassword method with redirectTo parameter including 2 query parameters, e.g. http://localhost:3000/setNewPassword?foo=bar&baz=qux

Current vs. Expected behavior

Current: Second parameter is missing (baz) since callbackURL is not encoded and it's interpret as a sibling for callbackURL (not as part of it) — http://localhost:3000/setNewPassword?foo=bar&token=bla-bla-bla
Expected: All passed query parameters passed to Set new Password URL inside callbackURL — http://localhost:3000/setNewPassword?foo=bar&baz=qux&token=bla-bla-bla

What version of Better Auth are you using?

1.2.7

Provide environment information

- macOS: Darwin 24.5.0 arm64 arm
- Browser: Firefox/Chrome/Safari (it doesn't matter)

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

No response

Originally created by @isnifer on GitHub (May 6, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. Call `forgetPassword` method with `redirectTo` parameter including 2 query parameters, e.g. `http://localhost:3000/setNewPassword?foo=bar&baz=qux` ### Current vs. Expected behavior Current: Second parameter is missing (`baz`) since callbackURL is not encoded and it's interpret as a sibling for `callbackURL` (not as part of it) — `http://localhost:3000/setNewPassword?foo=bar&token=bla-bla-bla` Expected: All passed query parameters passed to `Set new Password` URL inside `callbackURL` — `http://localhost:3000/setNewPassword?foo=bar&baz=qux&token=bla-bla-bla` ### What version of Better Auth are you using? 1.2.7 ### Provide environment information ```bash - macOS: Darwin 24.5.0 arm64 arm - Browser: Firefox/Chrome/Safari (it doesn't matter) ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context _No response_
GiteaMirror commented 2026-03-13 08:26:23 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (May 28, 2025):

thanks! i have included your commit as well.

@Kinfe123 commented on GitHub (May 28, 2025): thanks! i have included your commit as well.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#1170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?