github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[Improvement] Remove redundant index in DB schema (Drizzle) #1166

New Issue
Closed
opened 2026-03-13 08:26:09 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-03-13 08:26:09 -05:00
Owner
Copy Link

Originally created by @DiiiaZoTe on GitHub (May 6, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. Generate the Drizzle schema using the better-auth/cli

Current vs. Expected behavior

The current schema generated for the user table is as follows:

export const user = pgTable("user", {
  id: text("id").primaryKey(),
  name: text('name').notNull(),
  email: text('email').notNull().unique(),
  emailVerified: boolean('email_verified').notNull(),
  image: text('image'),
  createdAt: timestamp('created_at').notNull(),
  updatedAt: timestamp('updated_at').notNull(),
}, (t) => [
  index('user_email_idx').on(t.email)
]);

The explicitly defined user_email_idx index here is redundant.
The email column is being defined as unique (email TEXT UNIQUE NOT NULL) which will automatically create a unique btree index on the column.
The above is for postgresql but the same applies for mysql and sqlite.

It's really not an issue but it's also unnecessary overhead.

What version of Better Auth are you using?

1.2.7

Provide environment information

- Environment does not matter here

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

No response

Originally created by @DiiiaZoTe on GitHub (May 6, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. Generate the Drizzle schema using the better-auth/cli ### Current vs. Expected behavior The current schema generated for the `user` table is as follows: ``` export const user = pgTable("user", { id: text("id").primaryKey(), name: text('name').notNull(), email: text('email').notNull().unique(), emailVerified: boolean('email_verified').notNull(), image: text('image'), createdAt: timestamp('created_at').notNull(), updatedAt: timestamp('updated_at').notNull(), }, (t) => [ index('user_email_idx').on(t.email) ]); ``` The explicitly defined `user_email_idx` index here is redundant. The email column is being defined as unique (`email TEXT UNIQUE NOT NULL`) which will automatically create a unique btree index on the column. The above is for postgresql but the same applies for mysql and sqlite. It's really not an issue but it's also unnecessary overhead. ### What version of Better Auth are you using? 1.2.7 ### Provide environment information ```bash - Environment does not matter here ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context _No response_
GiteaMirror commented 2026-03-13 08:26:10 -05:00
Author
Owner
Copy Link

@MuntasirSZN commented on GitHub (May 13, 2025):

I generated with drizzle and user table doesn't have any index at all. Also, as documented, currently the schema generation doesn't add indexing, but is for the future.

Also auth config isn't valid.

@MuntasirSZN commented on GitHub (May 13, 2025): I generated with drizzle and user table doesn't have any `index` at all. Also, as documented, currently the schema generation doesn't add indexing, but is for the future. Also auth config isn't valid.
GiteaMirror commented 2026-03-13 08:26:11 -05:00
Author
Owner
Copy Link

@DiiiaZoTe commented on GitHub (May 13, 2025):

Weird idk why mine had it... I guess in that case I'll close this.

@DiiiaZoTe commented on GitHub (May 13, 2025): Weird idk why mine had it... I guess in that case I'll close this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#1166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?