github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #636] [CLOSED] feat: improve social auth with idToken on expo #11655

New Issue
Closed
opened 2026-04-13 07:55:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 07:55:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/636
Author: @pakenfit
Created: 11/23/2024
Status: ❌ Closed

Base: main ← Head: feature/enchance-social-idtoken-auth-expo

📝 Commits (2)

  • 1e311df feat: improve social auth with idToken on expo
  • 9d99a2b Merge branch 'better-auth:main' into feature/enchance-social-idtoken-auth-expo

📊 Changes

4 files changed (+73 additions, -4 deletions)

View changed files

📝 packages/better-auth/src/api/routes/sign-in.ts (+1 -0)
📝 packages/expo/src/client.ts (+14 -4)
📝 packages/expo/src/expo.test.ts (+32 -0)
📝 packages/expo/src/index.ts (+26 -0)

📄 Description

This PR enhances the google and apple social auth on expo using for example expo-apple-authentication and @react-native-google-signin/google-signin

It consists on:

  • After gettting the idToken from expo-apple-authentication or @react-native-google-signin/google-signin
  • Use social auth with idToken in body :
await authClient.signIn.social({
   provider: "google",
   callbackURL: "/home-screen",
   idToken: {
       token: response.data.idToken,
    },
});
  • The server returns the session data, user and a boolean idToken: true indicates the auth with idToken
  • The expo plugin server side intercepts the response and add cookie to the response body.
  • The expo plugin client side store the cookie in the secure storage.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/636 **Author:** [@pakenfit](https://github.com/pakenfit) **Created:** 11/23/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/enchance-social-idtoken-auth-expo` --- ### 📝 Commits (2) - [`1e311df`](https://github.com/better-auth/better-auth/commit/1e311df5541eeaecd4ea4b389886c71587cd7b41) feat: improve social auth with idToken on expo - [`9d99a2b`](https://github.com/better-auth/better-auth/commit/9d99a2be0d06f4f2292af5223aac2283b654d496) Merge branch 'better-auth:main' into feature/enchance-social-idtoken-auth-expo ### 📊 Changes **4 files changed** (+73 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/sign-in.ts` (+1 -0) 📝 `packages/expo/src/client.ts` (+14 -4) 📝 `packages/expo/src/expo.test.ts` (+32 -0) 📝 `packages/expo/src/index.ts` (+26 -0) </details> ### 📄 Description This PR enhances the `google` and `apple` social auth on `expo` using for example `expo-apple-authentication` and `@react-native-google-signin/google-signin` It consists on: - After gettting the `idToken` from `expo-apple-authentication` or `@react-native-google-signin/google-signin` - Use social auth with idToken in body : ```` await authClient.signIn.social({ provider: "google", callbackURL: "/home-screen", idToken: { token: response.data.idToken, }, }); ```` - The server returns the session data, user and a boolean `idToken: true` indicates the auth with `idToken` - The expo plugin server side intercepts the response and add cookie to the response body. - The expo plugin client side store the cookie in the secure storage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 07:55:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?