github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #98] [CLOSED] feat: use localhost as email domain in anonymous auth #11345

New Issue
Closed
opened 2026-04-13 07:42:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 07:42:34 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/98
Author: @typed-sigterm
Created: 10/5/2024
Status: ❌ Closed

Base: main ← Head: feat/use-localhost-for-anonymous-auth

📝 Commits (6)

  • a8723c4 feat: change email domain of anonymous auth
  • 709a8f1 test: update
  • 3e95d09 test: fix
  • f584c31 Merge branch 'better-auth:main' into feat/use-localhost-for-anonymous-auth
  • e8ab665 chore: tweak
  • ffb4a02 Merge remote-tracking branch 'upstream/main' into feat/use-localhost-for-anonymous-auth

📊 Changes

3 files changed (+16938 additions, -14446 deletions)

View changed files

📝 packages/better-auth/src/plugins/anonymous/anon.test.ts (+2 -0)
📝 packages/better-auth/src/plugins/anonymous/index.ts (+19 -5)
📝 pnpm-lock.yaml (+16917 -14441)

📄 Description

Although temporary-{timestamp}-better-auth@email.com is almost impossible to cause conflict, email.com may cause confusion 😕 Maybe the approach from Git is better: localhost.

PS: As localhost (actually not a domain) is different from other domains, it does not contain ., which may cause some RegExps to fail. May need to be explained in the docs.
PS 2: Considering support for clustering and concurrency, perhaps UUID or generateId() would be better than timestamp.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/98 **Author:** [@typed-sigterm](https://github.com/typed-sigterm) **Created:** 10/5/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/use-localhost-for-anonymous-auth` --- ### 📝 Commits (6) - [`a8723c4`](https://github.com/better-auth/better-auth/commit/a8723c4bb183f9f923215a8e12f41de9561a92c2) feat: change email domain of anonymous auth - [`709a8f1`](https://github.com/better-auth/better-auth/commit/709a8f10d54d6e76927579ebeed5cc8c5a1a3731) test: update - [`3e95d09`](https://github.com/better-auth/better-auth/commit/3e95d09d578ee165cb7facda44bab6fa2c2633ae) test: fix - [`f584c31`](https://github.com/better-auth/better-auth/commit/f584c31b6731f310db5087be33371de2697c42fd) Merge branch 'better-auth:main' into feat/use-localhost-for-anonymous-auth - [`e8ab665`](https://github.com/better-auth/better-auth/commit/e8ab665332d7b650044055c637e3eb5d3c831184) chore: tweak - [`ffb4a02`](https://github.com/better-auth/better-auth/commit/ffb4a0286ac14b58b2e66aa70efe455f6f0bf04f) Merge remote-tracking branch 'upstream/main' into feat/use-localhost-for-anonymous-auth ### 📊 Changes **3 files changed** (+16938 additions, -14446 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/anonymous/anon.test.ts` (+2 -0) 📝 `packages/better-auth/src/plugins/anonymous/index.ts` (+19 -5) 📝 `pnpm-lock.yaml` (+16917 -14441) </details> ### 📄 Description Although `temporary-{timestamp}-better-auth@email.com` is almost impossible to cause conflict, `email.com` may cause confusion 😕 Maybe the approach from Git is better: `localhost`. PS: As `localhost` (actually not a domain) is different from other domains, it does not contain `.`, which may cause some RegExps to fail. May need to be explained in the docs. PS 2: Considering support for clustering and concurrency, perhaps UUID or `generateId()` would be better than timestamp. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 07:42:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11345