github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-10-20 20:26:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #8911] Add guardrails for cookie integration plugin order to prevent silent missing Set-Cookie #11235

New Issue
Open
opened 2026-04-13 07:34:50 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 07:34:50 -05:00
Owner
Copy Link
Copy Source

Originally created by @h30s on GitHub (Apr 2, 2026).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/8911

Originally assigned to: @ping-maxwell on GitHub.

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

Yes.

When using Better Auth, cookie integration plugins (like nextCookies, tanstackStartCookies, etc.) must be placed last in the plugins[] array.

If they are not last, any cookies added by plugins that run after them are not forwarded to the framework cookie store. This leads to silent failures like:

  • session not persisting
  • 2FA breaking (INVALID_*_COOKIES)
  • null sessions or redirect loops

This behavior is not obvious and no warning/error is shown, making it hard to debug.

Describe the solution you'd like

Add a guardrail during betterAuth() initialization:

  • Detect cookie integration plugins (by plugin.id)
  • If they are not the last plugin:
    • show a clear warning (or throw in dev mode)

Example message:

Cookie integration plugins should be last. Otherwise some Set-Cookie headers may be silently dropped.

This would prevent common misconfiguration and improve DX.

Describe alternatives you've considered

A more robust solution would be to make execution order independent by ensuring cookie plugins always run last internally (e.g., via hook finalization or priority system).

But a warning-based guardrail is simpler and a good first step.

Additional context

This issue has come up multiple times where the fix was simply "move the cookie plugin to the end".

Adding a guardrail would prevent this recurring confusion and improve reliability of core auth flows.

Happy to open a PR if this approach sounds good 👍

Originally created by @h30s on GitHub (Apr 2, 2026). Original GitHub issue: https://github.com/better-auth/better-auth/issues/8911 Originally assigned to: @ping-maxwell on GitHub. ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. Yes. When using Better Auth, cookie integration plugins (like `nextCookies`, `tanstackStartCookies`, etc.) must be placed last in the `plugins[]` array. If they are not last, any cookies added by plugins that run after them are not forwarded to the framework cookie store. This leads to silent failures like: - session not persisting - 2FA breaking (INVALID_*_COOKIES) - null sessions or redirect loops This behavior is not obvious and no warning/error is shown, making it hard to debug. ### Describe the solution you'd like Add a guardrail during `betterAuth()` initialization: - Detect cookie integration plugins (by `plugin.id`) - If they are not the last plugin: - show a clear warning (or throw in dev mode) Example message: > Cookie integration plugins should be last. Otherwise some Set-Cookie headers may be silently dropped. This would prevent common misconfiguration and improve DX. ### Describe alternatives you've considered A more robust solution would be to make execution order independent by ensuring cookie plugins always run last internally (e.g., via hook finalization or priority system). But a warning-based guardrail is simpler and a good first step. ### Additional context This issue has come up multiple times where the fix was simply "move the cookie plugin to the end". Adding a guardrail would prevent this recurring confusion and improve reliability of core auth flows. Happy to open a PR if this approach sounds good 👍
GiteaMirror added the awaiting external contributorenhancement labels 2026-04-13 07:34:51 -05:00
GiteaMirror commented 2026-04-13 07:34:52 -05:00
Author
Owner
Copy Link
Copy Source

@h30s commented on GitHub (Apr 5, 2026):

Hey @ping-maxwell Can I pick this up and open a PR?

<!-- gh-comment-id:4188897181 --> @h30s commented on GitHub (Apr 5, 2026): Hey @ping-maxwell Can I pick this up and open a PR?
GiteaMirror commented 2026-04-13 07:34:53 -05:00
Author
Owner
Copy Link
Copy Source

@ping-maxwell commented on GitHub (Apr 9, 2026):

Hey @ping-maxwell Can I pick this up and open a PR?

go for it!

<!-- gh-comment-id:4214305077 --> @ping-maxwell commented on GitHub (Apr 9, 2026): > Hey [@ping-maxwell](https://github.com/ping-maxwell) Can I pick this up and open a PR? go for it!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels awaiting external contributor enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11235