github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #8900] Account enumeration via distinct error codes in checkPassword (utils/password.ts) #11228

New Issue
Closed
opened 2026-04-13 07:34:24 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-13 07:34:24 -05:00
Owner
Copy Link

Originally created by @alavesa on GitHub (Apr 1, 2026).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/8900

checkPassword throws CREDENTIAL_ACCOUNT_NOT_FOUND when no account exists and INVALID_PASSWORD when the password is wrong. An attacker can distinguish between valid and invalid accounts by observing the error code.

Impact: Account enumeration on the sign-in flow.

Note: Related to existing enumeration work in #5017 (OTP email) and #8096 (/change-email), but this is a separate code path in the credential sign-in flow.

Found by PatchPilots security audit.

Originally created by @alavesa on GitHub (Apr 1, 2026). Original GitHub issue: https://github.com/better-auth/better-auth/issues/8900 `checkPassword` throws `CREDENTIAL_ACCOUNT_NOT_FOUND` when no account exists and `INVALID_PASSWORD` when the password is wrong. An attacker can distinguish between valid and invalid accounts by observing the error code. **Impact:** Account enumeration on the sign-in flow. *Note: Related to existing enumeration work in #5017 (OTP email) and #8096 (/change-email), but this is a separate code path in the credential sign-in flow.* Found by [PatchPilots](https://github.com/alavesa/patchpilots) security audit.
GiteaMirror added the security label 2026-04-13 07:34:24 -05:00
GiteaMirror commented 2026-04-13 07:34:25 -05:00
Author
Owner
Copy Link

@alavesa commented on GitHub (Apr 7, 2026):

Thanks for the quick fix! This was found during a PatchPilots security audit (npx patchpilots security). Good to see it resolved.

<!-- gh-comment-id:4201398605 --> @alavesa commented on GitHub (Apr 7, 2026): Thanks for the quick fix! This was found during a PatchPilots security audit (npx patchpilots security). Good to see it resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?