github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #8897] OAuth state not verified in cookie-based strategy (state.ts) #11225

New Issue
Open
opened 2026-04-13 07:34:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 07:34:18 -05:00
Owner
Copy Link

Originally created by @alavesa on GitHub (Apr 1, 2026).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/8897

In parseGenericState when storeStateStrategy === 'cookie', the state value from the OAuth callback URL is never compared against the originally generated state value. The function only checks that the oauth_state cookie exists and can be decrypted — but doesn't verify that the returned state matches what was sent. The database strategy does perform this comparison.

Impact: Potential CSRF in OAuth flows using the cookie strategy.

Note: Existing issues (#5243, #7352, #6847, #5871) report state mismatch bugs — this is a different concern: the verification step itself is missing.

Found by PatchPilots security audit.

Originally created by @alavesa on GitHub (Apr 1, 2026). Original GitHub issue: https://github.com/better-auth/better-auth/issues/8897 In `parseGenericState` when `storeStateStrategy === 'cookie'`, the `state` value from the OAuth callback URL is never compared against the originally generated state value. The function only checks that the `oauth_state` cookie exists and can be decrypted — but doesn't verify that the returned state matches what was sent. The database strategy does perform this comparison. **Impact:** Potential CSRF in OAuth flows using the cookie strategy. *Note: Existing issues (#5243, #7352, #6847, #5871) report state mismatch bugs — this is a different concern: the verification step itself is missing.* Found by [PatchPilots](https://github.com/alavesa/patchpilots) security audit.
GiteaMirror added the securitybug labels 2026-04-13 07:34:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?