github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #8119] 2fa/magic-link in oauth2 flows needs documentation #11000

New Issue
Open
opened 2026-04-13 07:22:46 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-13 07:22:46 -05:00
Owner
Copy Link

Originally created by @till on GitHub (Feb 23, 2026).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/8119

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

Enable 2fa on an account and then try to complete an oauth2 flow.

Current vs. Expected behavior

I am using better-auth in an application written in Hono, so most/all my calls are on the backend.

Currently, most backend methods require me to inject oauth_query to keep the state, but these functions are different and don't handle it at all:

  • auth.api.verifyTOTP
  • auth.api.verifyBackupCode
  • auth.api.signInMagicLink
  • auth.api.magicLinkVerify

Injecting the oauth_query (via body) yields an API Error (e.g. for 2fa) or it gets silently ignored (magic-link), so I have to handle the redirect to consent manually.

What version of Better Auth are you using?

1.5.0-beta.16

System info

├── @better-auth/cli@1.5.0-beta.13
├── @better-auth/oauth-provider@1.5.0-beta.16
├── better-auth@1.5.0-beta.16

Which area(s) are affected? (Select all that apply)

Other

Auth config (if applicable)

Additional context

I've made it work with the following:

+      if (oauth_query) {
+        // Strip prompt=login — the user just re-authenticated via 2FA
+        const params = new URLSearchParams(oauth_query);
+        params.delete("prompt");
+        return c.redirect(`/api/auth/oauth2/authorize?${params}`);
+      }
Originally created by @till on GitHub (Feb 23, 2026). Original GitHub issue: https://github.com/better-auth/better-auth/issues/8119 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce Enable 2fa on an account and then try to complete an oauth2 flow. ### Current vs. Expected behavior I am using better-auth in an application written in Hono, so most/all my calls are on the backend. Currently, most backend methods require me to inject `oauth_query` to keep the state, but these functions are different and don't handle it at all: - `auth.api.verifyTOTP` - `auth.api.verifyBackupCode` - `auth.api.signInMagicLink` - `auth.api.magicLinkVerify` Injecting the `oauth_query` (via body) yields an API Error (e.g. for 2fa) or it gets silently ignored (magic-link), so I have to handle the redirect to consent manually. ### What version of Better Auth are you using? 1.5.0-beta.16 ### System info ```bash ├── @better-auth/cli@1.5.0-beta.13 ├── @better-auth/oauth-provider@1.5.0-beta.16 ├── better-auth@1.5.0-beta.16 ``` ### Which area(s) are affected? (Select all that apply) Other ### Auth config (if applicable) ```typescript ``` ### Additional context I've made it work with the following: ```diff + if (oauth_query) { + // Strip prompt=login — the user just re-authenticated via 2FA + const params = new URLSearchParams(oauth_query); + params.delete("prompt"); + return c.redirect(`/api/auth/oauth2/authorize?${params}`); + } ```
GiteaMirror added the docs label 2026-04-13 07:22:46 -05:00
GiteaMirror commented 2026-04-13 07:22:47 -05:00
Author
Owner
Copy Link

@till commented on GitHub (Feb 24, 2026):

For magic-link, you have to set the callbackURL to an absolue URI.

<!-- gh-comment-id:3951891496 --> @till commented on GitHub (Feb 24, 2026): For magic-link, you have to set the `callbackURL` to an absolue URI.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label docs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#11000
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?