github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #6972] [oauth-provider] the jwks_uri should respect jwksPath from jwt plugin #10687

New Issue
Closed
opened 2026-04-13 06:58:20 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 06:58:20 -05:00
Owner
Copy Link

Originally created by @alexdonh on GitHub (Dec 24, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/6972

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

It's about the auth server metadata where jwks_uri is defined.

Describe the solution you'd like

Firstly, kudos to @dvanmali for the oauth-provider an oauth 2.1 compliant plugin!

i was just wondering if it makes a little more sense to respect the jwksPath of jwt plugin when building metadata:

0492750c7e/packages/oauth-provider/src/metadata.ts (L30)

instead of

jwks_uri: overrides?.jwt_disabled
    ? undefined
    : (opts?.jwks?.remoteUrl ?? `${baseURL}/jwks`),

do

jwks_uri: overrides?.jwt_disabled
    ? undefined
    : (opts?.jwks?.remoteUrl ?? `${baseURL}/${opts?.jwks?.jwksPath ?? "jwks"}`),

Describe alternatives you've considered

N/A

Additional context

No response

Originally created by @alexdonh on GitHub (Dec 24, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/6972 ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. It's about the auth server metadata where `jwks_uri` is defined. ### Describe the solution you'd like Firstly, kudos to @dvanmali for the `oauth-provider` an oauth 2.1 compliant plugin! i was just wondering if it makes a little more sense to respect the `jwksPath` of `jwt` plugin when building metadata: https://github.com/better-auth/better-auth/blob/0492750c7e5e3ea7c188111a6e5fa82f793c7427/packages/oauth-provider/src/metadata.ts#L30 instead of ``` jwks_uri: overrides?.jwt_disabled ? undefined : (opts?.jwks?.remoteUrl ?? `${baseURL}/jwks`), ``` do ``` jwks_uri: overrides?.jwt_disabled ? undefined : (opts?.jwks?.remoteUrl ?? `${baseURL}/${opts?.jwks?.jwksPath ?? "jwks"}`), ``` ### Describe alternatives you've considered N/A ### Additional context _No response_
GiteaMirror added the locked label 2026-04-13 06:58:20 -05:00
GiteaMirror commented 2026-04-13 06:58:22 -05:00
Author
Owner
Copy Link

@better-auth-agent[bot] commented on GitHub (Dec 24, 2025):

Thank you for your issue description! It looks like you've identified a potential improvement regarding the jwks_uri in the metadata configuration for the MCP plugin, specifically in how it could respect the jwksPath from the jwt plugin.

To proceed, it seems that the suggestion is to modify the logic of how jwks_uri is constructed. Rather than directly linking to the default JWKS endpoint, your proposal suggests incorporating the customizable jwksPath. This adjustment appears to be relevant considering there are existing discussions and an open issue about ensuring that configurations are correctly reflected across the plugins involved, especially when using JWT.

Since this enhancement might require further deliberation and technical evaluation, I recommend waiting for feedback or further input on this suggestion from the Better Auth team. You can tag @bekacru or @ping__ for more insights or details regarding this implementation.

How does this approach align with your expectations, and do you have any additional questions or related topics you'd like to discuss?

If you need more help, tag @better-auth-agent in a comment so I can respond.

Diagram • Discord • GitHub

Diagram Join Star

<!-- gh-comment-id:3688674499 --> @better-auth-agent[bot] commented on GitHub (Dec 24, 2025): Thank you for your issue description! It looks like you've identified a potential improvement regarding the `jwks_uri` in the metadata configuration for the `MCP` plugin, specifically in how it could respect the `jwksPath` from the `jwt` plugin. To proceed, it seems that the suggestion is to modify the logic of how `jwks_uri` is constructed. Rather than directly linking to the default JWKS endpoint, your proposal suggests incorporating the customizable `jwksPath`. This adjustment appears to be relevant considering there are existing discussions and an open issue about ensuring that configurations are correctly reflected across the plugins involved, especially when using JWT. Since this enhancement might require further deliberation and technical evaluation, I recommend waiting for feedback or further input on this suggestion from the Better Auth team. You can tag @bekacru or @ping__ for more insights or details regarding this implementation. How does this approach align with your expectations, and do you have any additional questions or related topics you'd like to discuss? _If you need more help, tag @better-auth-agent in a comment so I can respond._ <!-- bot:webhook reply v1 --> [Diagram](https://repodiagrams.s3.eu-north-1.amazonaws.com/skyvern_ultra_detailed_interactive.html) • [Discord](https://discord.gg/fG2XXEuQX3) • [GitHub](https://github.com/Skyvern-AI/Skyvern) [![Diagram](https://img.shields.io/badge/Diagram-2b3137?style=flat-square)](https://repodiagrams.s3.eu-north-1.amazonaws.com/skyvern_ultra_detailed_interactive.html) [![Join](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&style=flat-square)](https://discord.gg/fG2XXEuQX3) [![Star](https://img.shields.io/badge/star-181717?logo=github&logoColor=white&style=flat-square)](https://github.com/Skyvern-AI/Skyvern)
GiteaMirror commented 2026-04-13 06:58:23 -05:00
Author
Owner
Copy Link

@dvanmali commented on GitHub (Dec 24, 2025):

Thanks so much @alexdonh! And nice catch, will patch shortly!

<!-- gh-comment-id:3690328830 --> @dvanmali commented on GitHub (Dec 24, 2025): Thanks so much @alexdonh! And nice catch, will patch shortly!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#10687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?