github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Origin Check Middleware Fails with Query Parameters in Relative URLs #1068

New Issue
Closed
opened 2026-03-13 08:21:08 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-03-13 08:21:08 -05:00
Owner
Copy Link

Originally created by @ejscheepers on GitHub (Apr 17, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

Ex:

  1. Add url parameter to redirectTo field of forgetPassword
  2. Try to send forget password email
  3. It works if you add in base url manually

Current vs. Expected behavior

Currently you get error that full url including url parameters is not trusted origin, should strip parameters and then check.

What version of Better Auth are you using?

1.2.7

Provide environment information

- Browser Safari

Which area(s) are affected? (Select all that apply)

Package

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

Image Image
Originally created by @ejscheepers on GitHub (Apr 17, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce Ex: 1. Add url parameter to redirectTo field of forgetPassword 2. Try to send forget password email 3. It works if you add in base url manually ### Current vs. Expected behavior Currently you get error that full url including url parameters is not trusted origin, should strip parameters and then check. ### What version of Better Auth are you using? 1.2.7 ### Provide environment information ```bash - Browser Safari ``` ### Which area(s) are affected? (Select all that apply) Package ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context <img width="736" alt="Image" src="https://github.com/user-attachments/assets/1e773d65-f18b-4ae0-9a4d-536fbe789658" /> <img width="636" alt="Image" src="https://github.com/user-attachments/assets/8741301d-fef8-4393-8cc2-b5b9d8ca1c52" />
GiteaMirror added the bug label 2026-03-13 08:21:08 -05:00
GiteaMirror commented 2026-03-13 08:21:13 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Apr 17, 2025):

the issue isn't having a query param but the "@" symbol. It'll be fixed.

@Bekacru commented on GitHub (Apr 17, 2025): the issue isn't having a query param but the "@" symbol. It'll be fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#1068
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?