github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #5015] callbackURL with query params not encoded correctly in email verification #10137

New Issue
Closed
opened 2026-04-13 06:04:26 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 06:04:26 -05:00
Owner
Copy Link

Originally created by @phuctm97 on GitHub (Oct 1, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/5015

Description

When using email verification (sign up flow), if the callbackURL contains query parameters or other non-URL-friendly characters, it is not being encoded correctly. This causes incorrect redirects after users click the verification link in their email.

Note: Password reset does not have this issue.

Expected Behavior

The callbackURL parameter should be properly URL-encoded (using encodeURIComponent or similar) when being included as a query parameter in the email verification URL.

Actual Behavior

The callbackURL is passed without proper encoding, which breaks when it contains:

  • Query parameters (e.g., ?redirect=/dashboard&tab=settings)
  • Special characters (e.g., #, &, =, etc.)

This causes the redirect URL to be malformed after email verification, leading to incorrect navigation or broken links.

Steps to Reproduce

  1. Initiate sign up with email verification using a callbackURL that includes query parameters
  2. Example: callbackURL = "https://example.com/app?redirect=/dashboard&tab=settings"
  3. Receive the verification email
  4. Click the link in the email
  5. Observe that the redirect after verification is incorrect due to malformed URL parsing

Environment

  • Better Auth version: 1.3.24
  • Affected feature: Email verification (sign up)
Originally created by @phuctm97 on GitHub (Oct 1, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/5015 ## Description When using email verification (sign up flow), if the `callbackURL` contains query parameters or other non-URL-friendly characters, it is not being encoded correctly. This causes incorrect redirects after users click the verification link in their email. **Note**: Password reset does not have this issue. ## Expected Behavior The `callbackURL` parameter should be properly URL-encoded (using `encodeURIComponent` or similar) when being included as a query parameter in the email verification URL. ## Actual Behavior The `callbackURL` is passed without proper encoding, which breaks when it contains: - Query parameters (e.g., `?redirect=/dashboard&tab=settings`) - Special characters (e.g., `#`, `&`, `=`, etc.) This causes the redirect URL to be malformed after email verification, leading to incorrect navigation or broken links. ## Steps to Reproduce 1. Initiate sign up with email verification using a `callbackURL` that includes query parameters 2. Example: `callbackURL = "https://example.com/app?redirect=/dashboard&tab=settings"` 3. Receive the verification email 4. Click the link in the email 5. Observe that the redirect after verification is incorrect due to malformed URL parsing ## Environment - Better Auth version: 1.3.24 - Affected feature: Email verification (sign up)
GiteaMirror added the lockedbug labels 2026-04-13 06:04:26 -05:00
GiteaMirror commented 2026-04-13 06:04:28 -05:00
Author
Owner
Copy Link

@dosubot[bot] commented on GitHub (Oct 1, 2025):

This is a known issue in Better Auth versions around 1.3.24: if the callbackURL contains query parameters or special characters, it may not be properly encoded in verification and password reset emails, leading to malformed redirects. The root cause is that the backend decodes the callbackURL before including it in the email link, which breaks URLs with &, =, etc. This has been discussed and confirmed in GitHub issue #4780.

A fix was implemented in a later beta version (see PR #3863), but it may not be present in 1.3.24. If you are on 1.3.24 and still experiencing this, you can:

  • Double-encode the callbackURL before sending it to the backend, then decode it twice on the frontend.
  • Manually parse the callbackURL on the frontend to handle any splitting issues.

Upgrading to a version that includes the fix from PR #3863 is the recommended long-term solution. For now, ensure you use encodeURIComponent when constructing the callbackURL and decodeURIComponent when reading it, as you suggested.

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other  Chat with Dosu Join Discord Share on X

<!-- gh-comment-id:3356087695 --> @dosubot[bot] commented on GitHub (Oct 1, 2025): <!-- Answer --> This is a known issue in Better Auth versions around 1.3.24: if the callbackURL contains query parameters or special characters, it may not be properly encoded in verification and password reset emails, leading to malformed redirects. The root cause is that the backend decodes the callbackURL before including it in the email link, which breaks URLs with `&`, `=`, etc. This has been discussed and confirmed in [GitHub issue #4780](https://github.com/better-auth/better-auth/issues/4780). A fix was implemented in a later beta version (see [PR #3863](https://github.com/better-auth/better-auth/pull/3863)), but it may not be present in 1.3.24. If you are on 1.3.24 and still experiencing this, you can: - Double-encode the callbackURL before sending it to the backend, then decode it twice on the frontend. - Manually parse the callbackURL on the frontend to handle any splitting issues. Upgrading to a version that includes the fix from PR #3863 is the recommended long-term solution. For now, ensure you use `encodeURIComponent` when constructing the callbackURL and `decodeURIComponent` when reading it, as you suggested. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/31b46f24-cd74-4f28-8b72-6cd2af7acb89?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/cdda13d9-dd27-4d31-b09a-5d8bec92de21/ask?utm_source=github)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/better-auth/better-auth/issues/5015)
GiteaMirror commented 2026-04-13 06:04:30 -05:00
Author
Owner
Copy Link

@phuctm97 commented on GitHub (Oct 1, 2025):

Found the buggy code:

f6cbdcc84e/packages/better-auth/src/api/routes/sign-up.ts (L279-L281)

19f39cb400/packages/better-auth/src/api/routes/email-verification.ts (L54-L56)

And many other places in those 2 files

<!-- gh-comment-id:3356104911 --> @phuctm97 commented on GitHub (Oct 1, 2025): Found the buggy code: https://github.com/better-auth/better-auth/blob/f6cbdcc84ee5d2971fdcc8b23ff7c174f88cf45b/packages/better-auth/src/api/routes/sign-up.ts#L279-L281 https://github.com/better-auth/better-auth/blob/19f39cb400d1b7afe925528bb58bccb8c3f077c3/packages/better-auth/src/api/routes/email-verification.ts#L54-L56 And many other places in those 2 files
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#10137
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?