github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Revoke impersonate session after stopping to impersonate #1008

New Issue
Closed
opened 2026-03-13 08:17:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 08:17:15 -05:00
Owner
Copy Link

Originally created by @MarcMogdanz on GitHub (Apr 8, 2025).

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

I've noticed that when you stop impersonating a user, it will not revoke the session that was created but rather just change out the impersonate session to your original admin user session.

Describe the solution you'd like

Ideally when calling the authClient.admin.stopImpersonating() function it should be possible to revoke the session totally. Since there's no way in the SDK to reuse the created impersonate session, there's no reason for it to exist anymore when the admin stopped impersonating. Starting to impersonate the same user will still trigger a new impersonate session to be created.

Describe alternatives you've considered

Currently I'm manually revoking the session when stopping to impersonate which works, but imo this should be part of the stopImpersonating() function itself

Additional context

No response

Originally created by @MarcMogdanz on GitHub (Apr 8, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. I've noticed that when you stop impersonating a user, it will not revoke the session that was created but rather just change out the impersonate session to your original admin user session. ### Describe the solution you'd like Ideally when calling the `authClient.admin.stopImpersonating()` function it should be possible to revoke the session totally. Since there's no way in the SDK to reuse the created impersonate session, there's no reason for it to exist anymore when the admin stopped impersonating. Starting to impersonate the same user will still trigger a new impersonate session to be created. ### Describe alternatives you've considered Currently I'm manually revoking the session when stopping to impersonate which works, but imo this should be part of the `stopImpersonating()` function itself ### Additional context _No response_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#1008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?