diff --git a/package.json b/package.json index d9e090bab5..1e17be00dd 100644 --- a/package.json +++ b/package.json @@ -23,7 +23,7 @@ "typescript": "5.5.0-dev.20240520" }, "simple-git-hooks": { - "pre-commit": "pnpm format && pnpm lint:fix" + "pre-commit": "pnpm typecheck && pnpm format && pnpm lint:fix" }, "devDependencies": { "simple-git-hooks": "^2.11.1" diff --git a/packages/better-auth/src/utils/secret.ts b/packages/better-auth/src/utils/secret.ts index f3683d61a0..f83a004bc9 100644 --- a/packages/better-auth/src/utils/secret.ts +++ b/packages/better-auth/src/utils/secret.ts @@ -1,10 +1,10 @@ import { MissingSecret } from "@better-auth/shared/error"; +export const DEFAULT_SECRET = "better-auth-secret-key-123456789"; export const getSecret = (secret?: string) => { secret = secret || process.env.BETTER_AUTH_SECRET || process.env.AUTH_SECRET; - const defaultSecret = "better-auth-secret-key-123456789"; if (process.env.NODE_ENV === "production" && !secret) { throw new MissingSecret(); } - return secret || defaultSecret; + return secret || DEFAULT_SECRET; }; diff --git a/packages/better-auth/tests/handler.test.ts b/packages/better-auth/tests/handler.test.ts index 224db6d90e..b1300ecca1 100644 --- a/packages/better-auth/tests/handler.test.ts +++ b/packages/better-auth/tests/handler.test.ts @@ -54,10 +54,6 @@ describe("to context", async () => { const options: BetterAuthOptions = { providers: [], adapter: memoryAdapter({}), - pages: { - signIn: "/", - signUp: "/", - }, user: { fields: { email: { type: "string", required: true }, diff --git a/packages/better-auth/tests/session.test.ts b/packages/better-auth/tests/session.test.ts index 3e01e118b8..e0942d51fc 100644 --- a/packages/better-auth/tests/session.test.ts +++ b/packages/better-auth/tests/session.test.ts @@ -7,6 +7,7 @@ import type { BetterAuthOptions } from "../src/options"; import { credential } from "../src/providers"; import { github } from "../src/providers/github"; import { getH3Server } from "./utils/server"; +import { DEFAULT_SECRET } from "../src/utils/secret"; describe("signin handler", async (it) => { const db = { @@ -14,7 +15,7 @@ describe("signin handler", async (it) => { { id: "1234", email: "test@email.com", - password: await hashPassword("test"), + password: await hashPassword("test", DEFAULT_SECRET), firstName: "Test", lastName: "User", }, diff --git a/packages/better-auth/tests/signin.test.ts b/packages/better-auth/tests/signin.test.ts index f7c4215f14..07f1c57859 100644 --- a/packages/better-auth/tests/signin.test.ts +++ b/packages/better-auth/tests/signin.test.ts @@ -6,6 +6,7 @@ import { hashPassword } from "../src/crypto/password"; import { credential } from "../src/providers"; import { github } from "../src/providers/github"; import { getH3Server } from "./utils/server"; +import { DEFAULT_SECRET } from "../src/utils/secret"; describe("signin handler", async (it) => { const db = { @@ -13,7 +14,7 @@ describe("signin handler", async (it) => { { id: "1234", email: "test@email.com", - password: await hashPassword("test"), + password: await hashPassword("test", DEFAULT_SECRET), firstName: "Test", lastName: "User", }, diff --git a/packages/better-auth/tests/signup.test.ts b/packages/better-auth/tests/signup.test.ts index 69f8214416..b542147ea2 100644 --- a/packages/better-auth/tests/signup.test.ts +++ b/packages/better-auth/tests/signup.test.ts @@ -130,10 +130,10 @@ describe("Signup", async () => { }); it("should verify email", async () => { - expect(db.user[0].emailVerified).toBe(false); + expect(db.user[0]?.emailVerified).toBe(false); const response = await app.request(verifyEmailUrl); const redirectedLocation = response.headers.get("Location"); - expect(db.user[0].emailVerified).toBe(true); + expect(db.user[0]?.emailVerified).toBe(true); expect(response.status).toBe(302); expect(redirectedLocation).toBe("http://localhost:4002"); });