From 24659aefc35a536b95ea4e5347e52c8803910153 Mon Sep 17 00:00:00 2001 From: Bereket Engida Date: Mon, 24 Feb 2025 12:25:04 +0300 Subject: [PATCH] fix(origin-check): prevent URLs with double slashes from being trusted --- packages/better-auth/src/api/middlewares/origin-check.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/better-auth/src/api/middlewares/origin-check.ts b/packages/better-auth/src/api/middlewares/origin-check.ts index 93e5c8ab9b..6d0a85370a 100644 --- a/packages/better-auth/src/api/middlewares/origin-check.ts +++ b/packages/better-auth/src/api/middlewares/origin-check.ts @@ -47,7 +47,10 @@ export const originCheckMiddleware = createAuthMiddleware(async (ctx) => { const isTrustedOrigin = trustedOrigins.some( (origin) => matchesPattern(url, origin) || - (url?.startsWith("/") && label !== "origin" && !url.includes(":")), + (url?.startsWith("/") && + label !== "origin" && + !url.includes(":") && + !url.includes("//")), ); if (!isTrustedOrigin) { ctx.context.logger.error(`Invalid ${label}: ${url}`);