github-starred/awesome-sindresorhus
2
0
Fork 0
mirror of https://github.com/sindresorhus/awesome.git synced 2026-07-26 02:51:16 -05:00
Code Issues 1.7k Packages Projects Releases Wiki Activity

Review pull_request_template.md and create-list.md #224

New Issue
Closed
opened 2025-11-06 15:09:47 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-06 15:09:47 -06:00
Owner
Copy Link
Copy Source

Originally created by @missmatsuko on GitHub (Jun 10, 2019).

create-list.md has at least 1 rule that's not in pull_request_template.md and could get missed by people making a PR:

Your awesome list should be named awesome-list-name"

I think these files could either be combined, or the PR template could be simplified (without removing rules), and create-list.md could have more details about each requirement.

I think if the PR template were more like a checklist or form, people would be able to follow it better.

I can give it a try, if you're ok with this suggestion.

Originally created by @missmatsuko on GitHub (Jun 10, 2019). create-list.md has at least 1 rule that's not in pull_request_template.md and could get missed by people making a PR: ``` Your awesome list should be named awesome-list-name" ``` I think these files could either be combined, or the PR template could be simplified (without removing rules), and create-list.md could have more details about each requirement. I think if the PR template were more like a checklist or form, people would be able to follow it better. I can give it a try, if you're ok with this suggestion.
GiteaMirror commented 2025-11-06 15:09:48 -06:00
Author
Owner
Copy Link
Copy Source

@zoidyzoidzoid commented on GitHub (Jul 4, 2019):

Having one canonical list with all the rules sounds valuable to me

@zoidyzoidzoid commented on GitHub (Jul 4, 2019): Having one canonical list with all the rules sounds valuable to me
GiteaMirror commented 2025-11-06 15:09:48 -06:00
Author
Owner
Copy Link
Copy Source

@sindresorhus commented on GitHub (Jul 4, 2019):

I think if the PR template were more like a checklist or form, people would be able to follow it better.

It used to be in checkbox form, but almost everyone checked stuff without actually adhering to it, so it ended up being a useless effort.

@sindresorhus commented on GitHub (Jul 4, 2019): > I think if the PR template were more like a checklist or form, people would be able to follow it better. It used to be in checkbox form, but almost everyone checked stuff without actually adhering to it, so it ended up being a useless effort.
GiteaMirror commented 2025-11-06 15:09:48 -06:00
Author
Owner
Copy Link
Copy Source

@sindresorhus commented on GitHub (Jul 4, 2019):

I think these files could either be combined, or the PR template could be simplified (without removing rules), and create-list.md could have more details about each requirement.

Good point. Fixed :)

@sindresorhus commented on GitHub (Jul 4, 2019): > I think these files could either be combined, or the PR template could be simplified (without removing rules), and create-list.md could have more details about each requirement. Good point. Fixed :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
help wanted
invalid
list request
pull-request
Mirrored from GitHub Pull Request
 question
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-sindresorhus#224