github-starred/awesome-selfhosted
2
0
Fork 0
mirror of https://github.com/awesome-selfhosted/awesome-selfhosted.git synced 2026-03-10 12:13:11 -05:00
Code Issues Packages Projects Releases 1 Wiki Activity

Validate pull requests with Travis #3998

New Issue
Closed
opened 2025-11-26 20:54:08 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-26 20:54:08 -06:00
Owner
Copy Link

Originally created by @awesome-bot on GitHub (Dec 18, 2015).

Hello, I wrote a tool that can validate README links (valid URLs, not duplicate). It can be run when someone submits a pull request.

It is currently being used by

Examples

If you are interested, connect this repo to https://travis-ci.org/ and add a .travis.yml file to the project.

See https://github.com/dkhamsing/awesome_bot for options, more information
Feel free to leave a comment 😄

Originally created by @awesome-bot on GitHub (Dec 18, 2015). Hello, I wrote a tool that can validate README links (valid URLs, not duplicate). It can be run when someone submits a pull request. It is currently being used by - https://github.com/vsouza/awesome-ios - https://github.com/matteocrippa/awesome-swift - https://github.com/dkhamsing/open-source-ios-apps Examples - https://travis-ci.org/matteocrippa/awesome-swift/builds/96526196 ok ✅ - https://travis-ci.org/matteocrippa/awesome-swift/builds/96722421 link redirected / rename 🔴 - https://travis-ci.org/dkhamsing/open-source-ios-apps/builds/96763135 bad link / project deleted 🔴 - https://travis-ci.org/dkhamsing/open-source-ios-apps/builds/95754715 dupe 🔴 If you are interested, connect this repo to https://travis-ci.org/ and add a [`.travis.yml`](https://github.com/dkhamsing/open-source-ios-apps/blob/master/.travis.yml) file to the project. See https://github.com/dkhamsing/awesome_bot for options, more information Feel free to leave a comment :smile:
GiteaMirror added the fix label 2025-11-26 20:54:08 -06:00
GiteaMirror commented 2025-11-26 20:54:08 -06:00
Author
Owner
Copy Link

@Kickball commented on GitHub (Dec 18, 2015):

While this seems like a great idea, I could see a problem that if any of the links within the project die (turn into 404s) it will stop all pull requests until that link is removed.

I'd like to see what @nodiscc thinks.

@Kickball commented on GitHub (Dec 18, 2015): While this seems like a great idea, I could see a problem that if any of the links within the project die (turn into 404s) it will stop all pull requests until that link is removed. I'd like to see what @nodiscc thinks.
GiteaMirror commented 2025-11-26 20:54:09 -06:00
Author
Owner
Copy Link

@awesome-bot commented on GitHub (Dec 18, 2015):

@Kickball well yeah it would show as having failed but it does not affect if you can merge or not.. that is separate

You should however review the script findings and see if any results warrant an action (remove projects that have been deleted, or update links).

A possible flow would be:

  1. user A submits a new link
  2. travis fails (found a project that has been deleted)
  3. collaborator reviews the results, sees the link added by A is fine: merges changes
  4. collaborator fixes issue found in travis
@awesome-bot commented on GitHub (Dec 18, 2015): @Kickball well yeah it would show as having failed but it does not affect if you can merge or not.. that is separate You should however review the script findings and see if any results warrant an action (remove projects that have been deleted, or update links). A possible flow would be: 1. user A submits a new link 2. travis fails (found a project that has been deleted) 3. collaborator reviews the results, sees the link added by A is fine: merges changes 4. collaborator fixes issue found in travis
GiteaMirror commented 2025-11-26 20:54:09 -06:00
Author
Owner
Copy Link

@Kickball commented on GitHub (Dec 18, 2015):

What I'd prefer would be this to be run as an external script (not attached to the pull request process), which will run on a set day (say Monday as our other script does #63) and will create an issue listing any dead/redirected sites in the repo.

@Kickball commented on GitHub (Dec 18, 2015): What I'd prefer would be this to be run as an external script (not attached to the pull request process), which will run on a set day (say Monday as our other script does #63) and will create an issue listing any dead/redirected sites in the repo.
GiteaMirror commented 2025-11-26 20:54:09 -06:00
Author
Owner
Copy Link

@awesome-bot commented on GitHub (Dec 18, 2015):

Yeah that is a good idea.. Travis integration assumes there is a low traffic of pull requests

@awesome-bot commented on GitHub (Dec 18, 2015): Yeah that is a good idea.. Travis integration assumes there is a low traffic of pull requests
GiteaMirror commented 2025-11-26 20:54:09 -06:00
Author
Owner
Copy Link

@arylatt commented on GitHub (Jan 25, 2016):

This functionality has been taken care of in the Awesome-Selfhosted Scanner. See #63 for more details.

@arylatt commented on GitHub (Jan 25, 2016): This functionality has been taken care of in the Awesome-Selfhosted Scanner. See #63 for more details.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
addition
curation
discussion
enhancement
feedback needed
fix
help wanted
invalid
license list
needs to mature
non-free
pull-request
Mirrored from GitHub Pull Request
 reviewers wanted
tools
No Label fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-selfhosted#3998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?