From b3222c4fcfc6bf1ac55ce6be3dc3225d2695bb75 Mon Sep 17 00:00:00 2001 From: Vinta Chen Date: Sun, 16 Aug 2026 20:41:52 +0800 Subject: [PATCH] chore: remove stale review-pending-prs command file Superseded by the rewritten .claude/skills/review-prs/SKILL.md committed just before (9ce2a21); leaving it in place would keep a stale second copy of the PR-review instructions. Co-Authored-By: Claude --- .claude/commands/review-pending-prs.md | 70 -------------------------- .claude/skills/review-prs/SKILL.md | 2 +- 2 files changed, 1 insertion(+), 71 deletions(-) delete mode 100644 .claude/commands/review-pending-prs.md diff --git a/.claude/commands/review-pending-prs.md b/.claude/commands/review-pending-prs.md deleted file mode 100644 index a026ce92..00000000 --- a/.claude/commands/review-pending-prs.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -description: Review pending PRs against CONTRIBUTING.md acceptance criteria. -allowed-tools: Bash(gh api:*), Bash(gh pr close:*), Bash(gh pr diff:*), Bash(gh pr edit:*), Bash(gh pr list:*) ---- - -## Usage - -``` -/review-pending-prs -``` - -## Instructions - -1. Fetch 10 open PRs with details: `gh pr list --repo vinta/awesome-python --limit 10 --search "-label:\"claude reviewed\"" --json number,title,author,url,body,files,mergeable,mergeStateStatus` -2. Fetch all PR diffs in parallel: `gh pr diff --repo vinta/awesome-python` -3. Run quick rejection checks (no API calls needed): - - Has merge conflicts? (from `mergeable`/`mergeStateStatus`) - - Adds more than one project? (from diff) - - Duplicate entry? (from diff - URL already in README) - - Not a project submission? (from diff - e.g., random files, contributor list) -4. For PRs passing quick checks, fetch repo stats: `gh api repos// --jq '{stars: .stargazers_count, created: .created_at, updated: .pushed_at, language: .language, archived: .archived}'` -5. Review against all criteria in [CONTRIBUTING.md](../../CONTRIBUTING.md) -6. Present summary table with recommendations -7. Ask user: - -``` -Would you like me to: - -1. Close the rejected PRs with comments? -2. Add "claude reviewed" label to the passed PRs? -3. Do all -``` - -## Quick Rejection Checks - -Check these rules first - if any fail, recommend rejection: - -- PR has merge conflicts -- Add more than one project per PR -- Duplicate of existing entry -- Placed under an inappropriate category -- Project is archived or abandoned (no commits in 12+ months) -- No documentation or unclear use case -- Less than 100 GitHub stars AND not justified as a hidden gem -- Too niche — a thin wrapper, single-function utility, or narrow edge-case tool that most Python developers would never need - -## Output Format - -Provide a simple review: - -1. **Rejection Check** - table with the above rules and PASS/REJECT -2. **Recommendation** - PASS or REJECT - -## Close PRs - -If user asks to close/reject: - -```bash -gh pr close --repo vinta/awesome-python --comment "" -``` - -## Mark as Passed - -```bash -gh pr edit --repo vinta/awesome-python --add-label "claude reviewed" -``` - -## Extra Instructions (If Provided) - -$ARGUMENTS diff --git a/.claude/skills/review-prs/SKILL.md b/.claude/skills/review-prs/SKILL.md index 4f0b05d0..a84c6c1c 100644 --- a/.claude/skills/review-prs/SKILL.md +++ b/.claude/skills/review-prs/SKILL.md @@ -25,7 +25,7 @@ Group survivors by target use case — PRs proposing entries for the same use ca ## 4. Act - **Close**: per closing PR, AskUserQuestion presenting the draft closing comment — the comment states the reason and links CONTRIBUTING.md. Arms: close with this comment, close without a comment, keep open. Then `gh pr close --repo vinta/awesome-python --comment ""`, or a plain close. -- **Merge**: `gh pr merge --repo vinta/awesome-python --merge`, then reconcile the section locally: `git pull`, remove the entry the verdict displaced, put the new entry at its Entry Ordering position, `UV_PYTHON=3.13 make test`, commit, push. An add-only diff that displaces is the normal case — the removal is this step's job, not the contributor's. +- **Merge**: `gh pr merge --repo vinta/awesome-python --merge`, then reconcile the section locally: `git pull`, remove the entry the verdict displaced, put the new entry at its Entry Ordering position, `make test`, commit, push. An add-only diff that displaces is the normal case — the removal is this step's job, not the contributor's. - **Park**: any reviewed PR left open gets `gh pr edit --repo vinta/awesome-python --add-label "claude reviewed"` so the next fetch skips it. ## 5. Report