[PR #793] [MERGED] Fix earnings call analyst ADK auth detection #4831

New Issue

GiteaMirror · 2026-05-12T07:46:30-05:00

GiteaMirror commented

2026-05-12 07:46:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/Shubhamsaboo/awesome-llm-apps/pull/793
Author: @Shubhamsaboo
Created: 5/8/2026
Status: ✅ Merged
Merged: 5/8/2026
Merged by: @Shubhamsaboo

Base: main ← Head: earnings-call-analyst-agent-adk-auth-fix

📝 Commits (1)

6320331 Fix earnings analyst ADK auth detection

📊 Changes

8 files changed (+161 additions, -248 deletions)

View changed files

📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md (+2 -2)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/adk_runtime.py (+38 -0)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/agent.py (+4 -105)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/live_demo/app.js (+6 -3)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/live_demo/server.py (+9 -4)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/research.py (+6 -98)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test_core_contracts.py (+90 -15)
📝 advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/youtube_ingest.py (+6 -21)

📄 Description

Summary

centralize ADK credential detection and JSON parsing for the Earnings Call Analyst Agent
treat Vertex AI env (GOOGLE_GENAI_USE_VERTEXAI=True + GOOGLE_CLOUD_PROJECT) as a valid ADK runtime path
make health/diagnostics report ADK auth mode instead of only checking for API keys
update tests to cover Vertex AI auth and the shared parser

Root cause

The app README was Vertex-first, but runtime gates in insights, research, transcription, health, and diagnostics were still duplicated around GOOGLE_API_KEY checks. Vertex-only runs could therefore fall back to local/RSS behavior or reject audio transcription instead of using ADK.

Validation

PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m py_compile __init__.py adk_runtime.py agent.py research.py schemas.py youtube_ingest.py live_demo/server.py
node --check live_demo/app.js
PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m pytest -p no:cacheprovider
Vertex-only smoke check returned auth_mode=vertex_ai and has_adk_credentials=True

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Shubhamsaboo/awesome-llm-apps/pull/793 **Author:** [@Shubhamsaboo](https://github.com/Shubhamsaboo) **Created:** 5/8/2026 **Status:** ✅ Merged **Merged:** 5/8/2026 **Merged by:** [@Shubhamsaboo](https://github.com/Shubhamsaboo) **Base:** `main` ← **Head:** `earnings-call-analyst-agent-adk-auth-fix` --- ### 📝 Commits (1) - [`6320331`](https://github.com/Shubhamsaboo/awesome-llm-apps/commit/6320331cd2a054eb4a2c823e3c96e3e32ec1ee97) Fix earnings analyst ADK auth detection ### 📊 Changes **8 files changed** (+161 additions, -248 deletions) <details> <summary>View changed files</summary> 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md` (+2 -2) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/adk_runtime.py` (+38 -0) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/agent.py` (+4 -105) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/live_demo/app.js` (+6 -3) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/live_demo/server.py` (+9 -4) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/research.py` (+6 -98) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test_core_contracts.py` (+90 -15) 📝 `advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/youtube_ingest.py` (+6 -21) </details> ### 📄 Description ## Summary - centralize ADK credential detection and JSON parsing for the Earnings Call Analyst Agent - treat Vertex AI env (`GOOGLE_GENAI_USE_VERTEXAI=True` + `GOOGLE_CLOUD_PROJECT`) as a valid ADK runtime path - make health/diagnostics report ADK auth mode instead of only checking for API keys - update tests to cover Vertex AI auth and the shared parser ## Root cause The app README was Vertex-first, but runtime gates in insights, research, transcription, health, and diagnostics were still duplicated around `GOOGLE_API_KEY` checks. Vertex-only runs could therefore fall back to local/RSS behavior or reject audio transcription instead of using ADK. ## Validation - `PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m py_compile __init__.py adk_runtime.py agent.py research.py schemas.py youtube_ingest.py live_demo/server.py` - `node --check live_demo/app.js` - `PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m pytest -p no:cacheprovider` - Vertex-only smoke check returned `auth_mode=vertex_ai` and `has_adk_credentials=True` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-12 07:46:30 -05:00

GiteaMirror closed this issue

2026-05-12 07:46:31 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/awesome-llm-apps#4831