Originally created by @therealprof on GitHub (Apr 8, 2018).
Originally assigned to: @berkus on GitHub.
This PR went in a bit overly quick and just after a rough review, I left a number of comments and nits which require addressing and possibly additional discussion hence this ticket.
Originally created by @therealprof on GitHub (Apr 8, 2018).
Originally assigned to: @berkus on GitHub.
This [PR](https://github.com/rust-embedded/awesome-embedded-rust/pull/12/files/b5456636f727de2587d64da3b84d5d6e3ab3767e) went in a bit overly quick and just after a rough review, I left a number of comments and nits which require addressing and possibly additional discussion hence this ticket.
I'll review the changes - agree that the list can be improved a lot, but i'm for a step-by-step approach. @rahul-thakoor I will get some time to address the nitpicks from @therealprof so no worries.
@berkus commented on GitHub (Apr 9, 2018):
I'll review the changes - agree that the list can be improved a lot, but i'm for a step-by-step approach. @rahul-thakoor I will get some time to address the nitpicks from @therealprof so no worries.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @therealprof on GitHub (Apr 8, 2018).
Originally assigned to: @berkus on GitHub.
This PR went in a bit overly quick and just after a rough review, I left a number of comments and nits which require addressing and possibly additional discussion hence this ticket.
@rahul-thakoor commented on GitHub (Apr 8, 2018):
oops, I might have messed up there, Can I help?
@berkus commented on GitHub (Apr 9, 2018):
I'll review the changes - agree that the list can be improved a lot, but i'm for a step-by-step approach. @rahul-thakoor I will get some time to address the nitpicks from @therealprof so no worries.
@therealprof commented on GitHub (Apr 17, 2018):
@berkus Any updates?
@berkus commented on GitHub (Apr 21, 2018):
Yep, was busy with work. Starting on it now.
@berkus commented on GitHub (May 1, 2018):
This is done.