mirror of
https://github.com/kitspace/awesome-electronics.git
synced 2026-07-16 06:12:51 -05:00
[GH-ISSUE #27] awesome_bot issues #2472
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @stevestock on GitHub (Apr 27, 2018).
Original GitHub issue: https://github.com/kitspace/awesome-electronics/issues/27
awesome_bot output below. I can make a PR if you're interested. You also may want to set up Travis CI to check this automatically like several other awesome lists.
@kasbah commented on GitHub (Apr 27, 2018):
I guess so, I don't think these are huge issues. So what if the URLs re-direct? The dupe KiCad link is intentional.
Would be nice to check for 404s I guess. But those can just be temporary too.
@stevestock commented on GitHub (Apr 27, 2018):
I don’t think they are huge issues either, just minor improvements.
Most redirects have a small impact to load time. Some, like link 01 (
linear.com to analog.com) could eventually be removed. Awesome_bot can be
configured to ignore dupes.
On Fri, Apr 27, 2018 at 08:43 Kaspar Emanuel notifications@github.com
wrote:
@kasbah commented on GitHub (Apr 27, 2018):
Sure, feel free to change these but I don't think I want CI complaining
about people adding links which re-direct. Detecting dupes on PRs could be
handy but only if it can be configured to ignore specific instances like
the one we already have.
@stevestock commented on GitHub (Apr 27, 2018):
Doesn’t look like it can ignore specific instances. I’ll make a PR tonight
for the issues it found. No worries if you don’t want to add an automatic
CI check, up to you. Just a suggestion.
On Fri, Apr 27, 2018 at 09:07 Kaspar Emanuel notifications@github.com
wrote: