github-starred/awesome-docker
2
0
Fork 0
mirror of https://github.com/veggiemonk/awesome-docker.git synced 2026-03-10 07:52:51 -05:00
Code Issues 5 Packages Projects Releases 1 Wiki Activity

CI tests all links for each PR #66

New Issue
Closed
opened 2025-11-06 11:25:06 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-06 11:25:06 -06:00
Owner
Copy Link

Originally created by @dmitrytokarev on GitHub (Jul 4, 2019).

@veggiemonk i think we need to rework the CI logic for this project.
I think for new PRs only changes need to be tested. That way builds would be way faster too.
And all links can be tested nightly and maintainers may opt to be notified for failures and decide to open PR to fix issues.

The reason is that contributors are blocked if any of the links fail from the whole of README.md. Yes, maintainers have the privilege ignore CI failures and merge but it’s just bad experience for everybody. I merge without that happy feeling that all tests passed, you know that feeling right? ;)

In the case of PR #715 i added lazydocker project and some other link failed.

Please see PR #715 comment https://github.com/veggiemonk/awesome-docker/pull/715#issuecomment-508440502 for details

Originally created by @dmitrytokarev on GitHub (Jul 4, 2019). @veggiemonk i think we need to rework the CI logic for this project. I think for new PRs only changes need to be tested. That way builds would be way faster too. And all links can be tested nightly and maintainers may opt to be notified for failures and decide to open PR to fix issues. The reason is that contributors are blocked if any of the links fail from the whole of README.md. Yes, maintainers have the privilege ignore CI failures and merge but it’s just bad experience for everybody. I merge without that happy feeling that all tests passed, you know that feeling right? ;) In the case of PR #715 i added lazydocker project and some other link failed. Please see PR #715 comment https://github.com/veggiemonk/awesome-docker/pull/715#issuecomment-508440502 for details
GiteaMirror commented 2025-11-06 11:25:07 -06:00
Author
Owner
Copy Link

@welcome[bot] commented on GitHub (Jul 4, 2019):

Thanks for opening your first issue here!

@welcome[bot] commented on GitHub (Jul 4, 2019): Thanks for opening your first issue here!
GiteaMirror commented 2025-11-06 11:25:07 -06:00
Author
Owner
Copy Link

@veggiemonk commented on GitHub (Jul 6, 2019):

Hi @dmitrytokarev thank you for contributing :D

I agree with you. Do you know how to test only the changes ?
Would you like to take care of that ?

@veggiemonk commented on GitHub (Jul 6, 2019): Hi @dmitrytokarev thank you for contributing :D I agree with you. Do you know how to test only the changes ? Would you like to take care of that ?
GiteaMirror commented 2025-11-06 11:25:07 -06:00
Author
Owner
Copy Link

@dmitrytokarev commented on GitHub (Jul 8, 2019):

It's doable. I would be able to look into this late July early August.

@dmitrytokarev commented on GitHub (Jul 8, 2019): It's doable. I would be able to look into this late July early August.
GiteaMirror commented 2025-11-06 11:25:08 -06:00
Author
Owner
Copy Link

@veggiemonk commented on GitHub (Jul 9, 2019):

Great! Let's sync up then. We could have a video call and discuss it.

Let's keep this open as a reminder.

Thanks

@veggiemonk commented on GitHub (Jul 9, 2019): Great! Let's sync up then. We could have a video call and discuss it. Let's keep this open as a reminder. Thanks
GiteaMirror commented 2025-11-06 11:25:08 -06:00
Author
Owner
Copy Link

@veggiemonk commented on GitHub (Oct 15, 2019):

ping @dmitrytokarev :)

@veggiemonk commented on GitHub (Oct 15, 2019): ping @dmitrytokarev :)
GiteaMirror commented 2025-11-06 11:25:09 -06:00
Author
Owner
Copy Link

@dmitrytokarev commented on GitHub (Oct 15, 2019):

It's been a while. I'll start working on this.

@dmitrytokarev commented on GitHub (Oct 15, 2019): It's been a while. I'll start working on this.
GiteaMirror commented 2025-11-06 11:25:09 -06:00
Author
Owner
Copy Link

@veggiemonk commented on GitHub (Jan 11, 2020):

This was fixed in the previous commits. Let's not fix something that is not broken (anymore :))

@veggiemonk commented on GitHub (Jan 11, 2020): This was fixed in the previous commits. Let's not fix something that is not broken (anymore :))
GiteaMirror commented 2025-11-06 11:25:09 -06:00
Author
Owner
Copy Link

@veggiemonk commented on GitHub (Jan 13, 2020):

The tests are now fixed @dmitrytokarev
So can we close this ?

@veggiemonk commented on GitHub (Jan 13, 2020): The tests are now fixed @dmitrytokarev So can we close this ?
GiteaMirror commented 2025-11-06 11:25:10 -06:00
Author
Owner
Copy Link

@dmitrytokarev commented on GitHub (Jan 16, 2020):

Agreed.

@dmitrytokarev commented on GitHub (Jan 16, 2020): Agreed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
broken-links
bug
cannot be evaluated
enhancement
health-report
help wanted
maintenance
pending-evaluation
pull-request
Mirrored from GitHub Pull Request
 question
team discussion
weekly-digest
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-docker#66
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?