mirror of
https://github.com/veggiemonk/awesome-docker.git
synced 2026-03-09 15:32:11 -05:00
remove style.min.css
#30
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/awesome-docker#30
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @agebhar1 on GitHub (Sep 14, 2017).
Originally assigned to: @gesellix, @vegasbrianc, @moshloop, @veggiemonk on GitHub.
Minified stylesheet
style.min.csswas introduced ate946c57200meta tags and min css as replacement of unminified versionstyle.css. Unfortunately at09ae203207Fix Table of Contentstyle.csswas re-introduced in addition to minified version. Consequently both versions where requested.I suggest to remove the minified version since
style.cssandstyle.min.cssare divergentstyle.min.css(don't forget to minifystyle.csseach time it's updated)style.css) vs. 8.1Kb (style.min.css) doesn't matterPlease vote via:
style.min.css)@gesellix commented on GitHub (Sep 14, 2017):
Though I normally don't agree with arguments like
I think in this case the maintenance aspect is more important. So looking at the current state my vote goes for 👍 .
Yet, I would try to find an automated way of updating the minified version. That would probably imply some more advanced configuration of Travis-CI and I'm not sure if we need such a setup only for some optimisation.
@agebhar1 commented on GitHub (Sep 14, 2017):
You're right @gesellix size is a bad argument 😃.
If we don't care about the Travis-CI setup (only @veggiemonk might be able). Each check on Travis-CI builds the minified version of
sytle.cssand push automatically to branchgh-pages. Consequently the default view must be changed togh-pages. As a result the minified version could be removed from themainbranch and is a build artefact.@gesellix commented on GitHub (Sep 14, 2017):
:-)
I agree, the minified version should be considered as a build artifact!
@veggiemonk commented on GitHub (Sep 14, 2017):
there is no point at being super efficient. Removing the min.css is better. Ease of maintenance is better for now.
Also for info, the
gh-pagesis useless. Everything is in master, it's much simpler to manage like that. And the list is automatically updated because it fetch and converts the readme while loading the page.