github-starred/awesome-compose
2
0
Fork 0
mirror of https://github.com/docker/awesome-compose.git synced 2026-03-09 06:52:08 -05:00
Code Issues 627 Packages Projects Releases Wiki Activity

Screenshots for React-Java-MySQL are off #657

New Issue
Closed
opened 2026-03-07 21:21:12 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-03-07 21:21:12 -06:00
Owner
Copy Link

Originally created by @JalexChen on GitHub (Sep 13, 2022).

I understand this is a very small issue but the screenshots in the README for the mentioned directory is a bit off and/or outdated, and I only ran into this when my CI build was failing as a result.

I was testing for react-java-mysql_backend when in reality, the container was named react-java-mysql-backend

Screen Shot 2022-09-13 at 2 49 22 PM

Might be a coincidence but my lead posted a relevant article just today which I thought was humorous: https://joshtronic.com/2022/08/21/screenshots-are-not-documentation/

Thank you Docker team for providing this repository! :)

Originally created by @JalexChen on GitHub (Sep 13, 2022). I understand this is a very small issue but the screenshots in the README for the mentioned [directory](https://github.com/docker/awesome-compose/tree/master/react-java-mysql) is a bit off and/or outdated, and I only ran into this when my CI build was failing as a result. I was testing for `react-java-mysql_backend` when in reality, the container was named `react-java-mysql-backend` ![Screen Shot 2022-09-13 at 2 49 22 PM](https://user-images.githubusercontent.com/14379129/190015857-fc8da0e8-e448-4fa3-af1c-998f296f0c7f.png) Might be a coincidence but my lead posted a relevant article just today which I thought was humorous: https://joshtronic.com/2022/08/21/screenshots-are-not-documentation/ Thank you Docker team for providing this repository! :)
GiteaMirror commented 2026-03-07 21:21:13 -06:00
Author
Owner
Copy Link

@nicksieger commented on GitHub (Sep 13, 2022):

You're right, good eye! A lot of the READMEs appear to show output from compose v1. In compose v2 we're using dashes instead of underscores for image and container names. The format is a bit different as well. Would you mind submitting a PR for those changes? A lot of the samples need updating, but feel free to just update the react-java-mysql one.

@nicksieger commented on GitHub (Sep 13, 2022): You're right, good eye! A lot of the READMEs appear to show output from compose v1. In compose v2 we're using dashes instead of underscores for image and container names. The format is a bit different as well. Would you mind submitting a PR for those changes? A lot of the samples need updating, but feel free to just update the react-java-mysql one.
GiteaMirror commented 2026-03-07 21:21:13 -06:00
Author
Owner
Copy Link

@JalexChen commented on GitHub (Sep 14, 2022):

Sure thing. I thought they were screenshots initially but I've just submitted a PR

@JalexChen commented on GitHub (Sep 14, 2022): Sure thing. I thought they were screenshots initially but I've just submitted a PR
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
proposal
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-compose#657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?