[PR #580] fix: align vuejs README port mapping with actual behavior #576

Open
opened 2025-11-06 14:29:07 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/docker/awesome-compose/pull/580
Author: @moinloin
Created: 4/20/2025
Status: 🔄 Open

Base: masterHead: fix/vuejs-readme-port-mapping


📝 Commits (1)

  • a692fe3 fix: align vuejs README port mapping with actual behavior

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 vuejs/README.md (+1 -1)

📄 Description

Fix: Align vuejs README port mapping with actual configuration

This pull request updates the vuejs/README.md to ensure consistency between the explanation and the docker-compose.yml example.

Changes made:

  • Updated the explanation text to reflect that port 8080 on the host is mapped to port 8080 in the container.
  • Updated the docker-compose.yml snippet to use "8080:8080" instead of "80:8080".

Why:

The previous example showed "80:8080", which didn't match the accompanying explanation or the actual behavior. This fix ensures clarity and avoids confusion for users following the guide.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/docker/awesome-compose/pull/580 **Author:** [@moinloin](https://github.com/moinloin) **Created:** 4/20/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/vuejs-readme-port-mapping` --- ### 📝 Commits (1) - [`a692fe3`](https://github.com/docker/awesome-compose/commit/a692fe3af1b6fddbf8c8a661dbe417a9fe0c568a) fix: align vuejs README port mapping with actual behavior ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `vuejs/README.md` (+1 -1) </details> ### 📄 Description ## Fix: Align vuejs README port mapping with actual configuration This pull request updates the `vuejs/README.md` to ensure consistency between the explanation and the `docker-compose.yml` example. ### Changes made: - Updated the explanation text to reflect that port `8080` on the host is mapped to port `8080` in the container. - Updated the `docker-compose.yml` snippet to use `"8080:8080"` instead of `"80:8080"`. ### Why: The previous example showed `"80:8080"`, which didn't match the accompanying explanation or the actual behavior. This fix ensures clarity and avoids confusion for users following the guide. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-06 14:29:07 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-compose#576