github-starred/awesome-compose
2
0
Fork 0
mirror of https://github.com/docker/awesome-compose.git synced 2026-03-09 06:52:08 -05:00
Code Issues 627 Packages Projects Releases Wiki Activity

[PR #405] Updated README.md at /react-express-mongodb /backend/ #429

New Issue
Open
opened 2025-11-06 14:26:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-06 14:26:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/docker/awesome-compose/pull/405
Author: @Thoshinny-cyber
Created: 12/8/2023
Status: 🔄 Open

Base: master ← Head: Thoshinny-cyber/react-express-mongodb-/backend/README.md

📝 Commits (1)

  • c2071c0 Updated README.md at /react-express-mongodb /backend/

📊 Changes

1 file changed (+11 additions, -9 deletions)

View changed files

📝 react-express-mongodb/backend/README.md (+11 -9)

📄 Description

Enhanced Dockerfile snippet and it's explanation in README.md

The Dockerfile snippet in the README.md file required adjustments to align it more closely with the actual Dockerfiles in both the Backend and Frontend directories. I've made few improvements to ensure clarity and accuracy.

Original Snippet in Repository:

FROM node:13.13.0-stretch-slim
# Argument passed from docker-compose.yaml file
ARG NODE_PORT
# Echo the argument to check if it's loaded correctly RUN echo "Argument port is: $NODE_PORT"
# Create app directory
WORKDIR /usr/src/app
# Copy entire content
COPY . .
# Install app dependencies
RUN npm install
#In my case my app binds to port NODE_PORT so you'll use the EXPOSE instruction to have it mapped by the docker daemon:
EXPOSE ${NODE_PORT}
CMD npm run dev

Modified Snippet:

FROM node:13.13.0-stretch-slim
#Argument that is passed from docker-compose.yaml file
ARG NODE_PORT
#Echo the argument to check passed argument loaded here correctly
RUN echo "Argument port is : $NODE_PORT"
# Create app directory
WORKDIR /usr/src/app
# Copy dependency definitions
COPY package.json /usr/src/app
# Install app dependencies
RUN npm install
# Get all the code needed to run the app
COPY . /usr/src/app
#In my case my app binds to port NODE_PORT so you'll use the EXPOSE instruction to have it mapped by the docker daemon:
EXPOSE ${NODE_PORT}
CMD npm run dev

These changes ensure better understanding and readability.

I've updated the README.md explanation for the updated snippet.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/docker/awesome-compose/pull/405 **Author:** [@Thoshinny-cyber](https://github.com/Thoshinny-cyber) **Created:** 12/8/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `Thoshinny-cyber/react-express-mongodb-/backend/README.md` --- ### 📝 Commits (1) - [`c2071c0`](https://github.com/docker/awesome-compose/commit/c2071c0e1433835b2fb57b49ba0ed699533078d4) Updated README.md at /react-express-mongodb /backend/ ### 📊 Changes **1 file changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `react-express-mongodb/backend/README.md` (+11 -9) </details> ### 📄 Description **Enhanced Dockerfile snippet and it's explanation in README.md** The Dockerfile snippet in the README.md file required adjustments to align it more closely with the actual Dockerfiles in both the Backend and Frontend directories. I've made few improvements to ensure clarity and accuracy. Original Snippet in Repository: ```bash FROM node:13.13.0-stretch-slim # Argument passed from docker-compose.yaml file ARG NODE_PORT # Echo the argument to check if it's loaded correctly RUN echo "Argument port is: $NODE_PORT" # Create app directory WORKDIR /usr/src/app # Copy entire content COPY . . # Install app dependencies RUN npm install #In my case my app binds to port NODE_PORT so you'll use the EXPOSE instruction to have it mapped by the docker daemon: EXPOSE ${NODE_PORT} CMD npm run dev ``` Modified Snippet: ```bash FROM node:13.13.0-stretch-slim #Argument that is passed from docker-compose.yaml file ARG NODE_PORT #Echo the argument to check passed argument loaded here correctly RUN echo "Argument port is : $NODE_PORT" # Create app directory WORKDIR /usr/src/app # Copy dependency definitions COPY package.json /usr/src/app # Install app dependencies RUN npm install # Get all the code needed to run the app COPY . /usr/src/app #In my case my app binds to port NODE_PORT so you'll use the EXPOSE instruction to have it mapped by the docker daemon: EXPOSE ${NODE_PORT} CMD npm run dev ``` These changes ensure better understanding and readability. I've updated the README.md explanation for the updated snippet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-06 14:26:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
proposal
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-compose#429
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?