github-starred/awesome-compose
2
0
Fork 0
mirror of https://github.com/docker/awesome-compose.git synced 2026-03-09 06:52:08 -05:00
Code Issues 627 Packages Projects Releases Wiki Activity

What is the purpose of COPY --from=gloursdocker/docker / /? #101

New Issue
Open
opened 2025-11-06 14:18:38 -06:00 by GiteaMirror · 10 comments
GiteaMirror commented 2025-11-06 14:18:38 -06:00
Owner
Copy Link

Originally created by @lucassus on GitHub (Nov 6, 2023).

This instruction, for some reason, is used in many examples.
The comment install Docker tools (cli, buildx, compose) in my opinion, is not really helpful.

Originally created by @lucassus on GitHub (Nov 6, 2023). This instruction, for some reason, is used in many examples. The comment `install Docker tools (cli, buildx, compose)` in my opinion, is not really helpful.
GiteaMirror commented 2025-11-06 14:18:41 -06:00
Author
Owner
Copy Link

@zozitak commented on GitHub (Nov 15, 2023):

google search first result to "gloursdocker/docker" :
https://registry.hub.docker.com/layers/gloursdocker/docker/latest/images/sha256-a66243282b1165f556ec4a91d749c1ebc81dd28bcfbce653ccf49b01ae3b3fdf

@zozitak commented on GitHub (Nov 15, 2023): google search first result to "gloursdocker/docker" : https://registry.hub.docker.com/layers/gloursdocker/docker/latest/images/sha256-a66243282b1165f556ec4a91d749c1ebc81dd28bcfbce653ccf49b01ae3b3fdf
GiteaMirror commented 2025-11-06 14:18:41 -06:00
Author
Owner
Copy Link

@lucassus commented on GitHub (Nov 15, 2023):

@zozitak thank you. I saw it, but still it's pretty hard to figure out what it exactly does.

@lucassus commented on GitHub (Nov 15, 2023): @zozitak thank you. I saw it, but still it's pretty hard to figure out what it exactly does.
GiteaMirror commented 2025-11-06 14:18:41 -06:00
Author
Owner
Copy Link

@admincodes7 commented on GitHub (Apr 28, 2024):

Copying all the contents of the root directory (/) from the gloursdocker/docker image into the root directory (/) of the current build stage

@admincodes7 commented on GitHub (Apr 28, 2024): Copying all the contents of the root directory (/) from the `gloursdocker/docker` image into the root directory (/) of the current build stage
GiteaMirror commented 2025-11-06 14:18:42 -06:00
Author
Owner
Copy Link

@ehhc commented on GitHub (Apr 30, 2024):

Copying all the contents of the root directory (/) from the gloursdocker/docker image into the root directory (/) of the current build stage

Thanks for your answer. I believe, most of us here understand, what that command literally does. I hopped for a bit more explanation on why the root directory was copied and some elaboration about the effects of this copying…

@ehhc commented on GitHub (Apr 30, 2024): > Copying all the contents of the root directory (/) from the `gloursdocker/docker` image into the root directory (/) of the current build stage Thanks for your answer. I believe, most of us here understand, what that command literally does. I hopped for a bit more explanation on why the root directory was copied and some elaboration about the effects of this copying…
GiteaMirror commented 2025-11-06 14:18:42 -06:00
Author
Owner
Copy Link

@admincodes7 commented on GitHub (Apr 30, 2024):

Copying all the contents of the root directory (/) from the gloursdocker/docker image into the root directory (/) of the current build stage

Thanks for your answer. I believe, most of us here understand, what that command literally does. I hopped for a bit more explanation on why the root directory was copied and some elaboration about the effects of this copying…

When you build a Docker image, each instruction in the Dockerfile creates a new layer on top of the previous one

gloursdocker/docker this is the official docker image which has all the base files required for the application

so here we are copying the entire contents of the gloursdocker/docker to our docker image
as there is already an image of gloursdocker/docker which is official image of docker

we need not build the same image again and used the cached one from gloursdocker/docker
also coming to the question 'why the root directory was copied'

  • to include the entire contents of that base image as the foundation for the new Docker image being built
@admincodes7 commented on GitHub (Apr 30, 2024): > > Copying all the contents of the root directory (/) from the `gloursdocker/docker` image into the root directory (/) of the current build stage > > Thanks for your answer. I believe, most of us here understand, what that command literally does. I hopped for a bit more explanation on why the root directory was copied and some elaboration about the effects of this copying… When you build a Docker image, each instruction in the Dockerfile creates a new layer on top of the previous one `gloursdocker/docker` this is the official docker image which has all the base files required for the application so here we are copying the entire contents of the `gloursdocker/docker` to our docker image as there is already an image of `gloursdocker/docker` which is official image of docker we need not build the same image again and used the cached one from `gloursdocker/docker` also coming to the question 'why the root directory was copied' - to include the entire contents of that base image as the foundation for the new Docker image being built
GiteaMirror commented 2025-11-06 14:18:42 -06:00
Author
Owner
Copy Link

@antun commented on GitHub (Aug 27, 2024):

I found this thread after asking myself the same question, and like @lucassus , I'm still unclear of what the purpose of the line is?

I understand it copies some files from the gloursdocker/docker image, but those files are not required for the fastapi application. If you remove that line, the fastapi will still build/run successfully.

The files it copies - such as docker and docker-compose - are used from the host rather than inside the container, so the purpose of copying them into an image during build time is a mystery. Maybe there's a specific use case, but I can't think of what it might be.

@antun commented on GitHub (Aug 27, 2024): I found this thread after asking myself the same question, and like @lucassus , I'm still unclear of what the purpose of the line is? I understand it copies some files from the `gloursdocker/docker` image, but those files are **not** required for the fastapi application. If you remove that line, the fastapi will still build/run successfully. The files it copies - such as docker and docker-compose - are used from the host rather than inside the container, so the purpose of copying them into an image during build time is a mystery. Maybe there's a specific use case, but I can't think of what it might be.
GiteaMirror commented 2025-11-06 14:18:43 -06:00
Author
Owner
Copy Link

@lucassus commented on GitHub (Aug 30, 2024):

TBH my first thought was that this copy from gloursdocker/docker might be a way to inject some malware. Imagine a situation where someone silently does something nasty with this image.

@lucassus commented on GitHub (Aug 30, 2024): TBH my first thought was that this copy from gloursdocker/docker might be a way to inject some malware. Imagine a situation where someone silently does something nasty with this image.
GiteaMirror commented 2025-11-06 14:18:44 -06:00
Author
Owner
Copy Link

@AngryVelociraptor commented on GitHub (Oct 20, 2024):

TBH my first thought was that this copy from gloursdocker/docker might be a way to inject some malware. Imagine a situation where someone silently does something nasty with this image.

Yes, this is my thought as well. An example repository where lots of devs copy/paste from is an ideal place to slip some malware into.
@glours needs to provide some explanation here. As it stands, I find this deeply suspicious.

@AngryVelociraptor commented on GitHub (Oct 20, 2024): > TBH my first thought was that this copy from gloursdocker/docker might be a way to inject some malware. Imagine a situation where someone silently does something nasty with this image. Yes, this is my thought as well. An example repository where lots of devs copy/paste from is an ideal place to slip some malware into. @glours needs to provide some explanation here. As it stands, I find this deeply suspicious.
GiteaMirror commented 2025-11-06 14:18:44 -06:00
Author
Owner
Copy Link

@mikesir87 commented on GitHub (Oct 20, 2024):

Thanks all for raising this! I'll be sure to raise this internally and see if we can get this resolved ASAP.

The reasoning for it... many of the examples in this repo were previously updated to support Docker's dev environment feature, which required additional support and tooling inside of the image. Since then, dev environments have been deprecated and the Compsoe-based configuration was removed. But, it appears the Dockerfiles were not updated.

We'll get it fixed. And yes, it is understandable to have security concerns for this. In the meantime, feel free to ignore this line as it should not affect the running of any of the examples in this repo.

@mikesir87 commented on GitHub (Oct 20, 2024): Thanks all for raising this! I'll be sure to raise this internally and see if we can get this resolved ASAP. The reasoning for it... many of the examples in this repo were previously updated to support Docker's dev environment feature, which required additional support and tooling inside of the image. Since then, dev environments have been deprecated and the Compsoe-based configuration was removed. But, it appears the Dockerfiles were not updated. We'll get it fixed. And yes, it is understandable to have security concerns for this. In the meantime, feel free to ignore this line as it should not affect the running of any of the examples in this repo.
GiteaMirror commented 2025-11-06 14:18:44 -06:00
Author
Owner
Copy Link

@OneCricketeer commented on GitHub (Oct 27, 2024):

I feel like I've seen an "ad" for Dev Environments in Docker Desktop, but I assumed that was another name for .devcontainer? If not, it would be nice to see that offered as an alternative to whatever this Dev Environment feature was.

@OneCricketeer commented on GitHub (Oct 27, 2024): I feel like I've seen an "ad" for Dev Environments in Docker Desktop, but I assumed that was another name for `.devcontainer`? If not, it would be nice to see that offered as an alternative to whatever this Dev Environment feature was.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
proposal
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/awesome-compose#101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?