mirror of
https://github.com/sdras/awesome-actions.git
synced 2026-07-16 19:42:13 -05:00
[GH-ISSUE #98] Checks not working on all PR's #9444
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/awesome-actions#9444
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gep13 on GitHub (Mar 4, 2019).
Original GitHub issue: https://github.com/sdras/awesome-actions/issues/98
For example, there are no checks on this PR:
https://github.com/sdras/awesome-actions/pull/97/checks
@sdras I am not able to see the settings of this repository, are you able to confirm how the settings are set up in this area? It would be good to have the awesome-lint action that @max added to this repository working on all PR's.
@xt0rted commented on GitHub (Mar 4, 2019):
I think the workflow needs to be changed from
pushtopull_request. Or a second workflow added forpull_request.@gep13 commented on GitHub (Mar 4, 2019):
@xt0rted I think you could be right! Thanks for posting here.
Would you mind creating a new PR on this repo to test this out? I have switched the workflow to trigger on
pull_request.@xt0rted commented on GitHub (Mar 4, 2019):
#99 I'm not seeing any checks yet though 😕
It worked in my fork https://github.com/xt0rted/awesome-actions/pull/2/checks
@gep13 commented on GitHub (Mar 4, 2019):
@xt0rted I am starting to think that there is a setting that is required to make this work, but not sure what...
I will reach out to someone who might be able to help.
@gep13 commented on GitHub (Mar 4, 2019):
@xt0rted The checks also showed up correctly on a PR that I raised here:
https://github.com/sdras/awesome-actions/pull/96
This was before switching to
pull_requestas well.@xt0rted commented on GitHub (Mar 7, 2019):
I set up a new workflow yesterday and had everything running on
pull_requestbut what I found was even updating a PR's labels triggered the actions to run. I think you were right having this run onpushbecause when I changed it over topushit continued running for commits but not for other changes (labels, projects, etc.).@gep13 commented on GitHub (Mar 7, 2019):
@xt0rted while you are here... was this on a private repo you were testing? I seem to remember that there is a limitation on what works on a public repo while in the GitHub Actions beta.
@gep13 commented on GitHub (Mar 7, 2019):
@xt0rted for now, I have switched back to the push event.
@xt0rted commented on GitHub (Mar 7, 2019):
It was a private repo where they were running after changing the labels of a PR. It makes sense after looking at the api more, the
pull_requestevent is fired for anything related to a PR.According to https://developer.github.com/actions/creating-workflows/workflow-configuration-options/#pull-request-events-for-forked-repositories
Also found https://developer.github.com/actions/changes/2018-12-18-limited-public-actions/
I'm not sure if this update changed any of that though https://developer.github.com/actions/changes/2019-01-29-public-actions-update/
@gep13 commented on GitHub (Mar 7, 2019):
Hmm, very strange then. I will follow up directly with GitHub support, to see if I can get an answer.
@gep13 commented on GitHub (Mar 16, 2019):
@xt0rted I have heard back from GitHub support on this, seems like this is known issue 😢
Guess we will simply have to wait and see if/when this ships. This is a real shame. Seems like this is an obvious thing that should/needs to be supported.
@gep13 commented on GitHub (Mar 16, 2019):
This does explain why the checks appeared on the PR that I created, as this from a PR from this repository, and not a fork.
@cryptiklemur commented on GitHub (Aug 19, 2019):
Oof. That is quite the deal breaker... What a bummer
@gep13 commented on GitHub (Aug 19, 2019):
@aequasi I am actually curious if this now “just works” would you be willing to test this out by sending a PR into this repo?
@max commented on GitHub (Aug 19, 2019):
@gep13 This will not “just work”. We’ve recently launched an updated version of GitHub Actions that does enable this workflow. I can flag this repository in but it requires updating the configuration file – we have changed the format. I’m happy to send you all a PR...
@gep13 commented on GitHub (Aug 19, 2019):
@max oh wow! If you could do both of those things, that would be great, thank you!
@cryptiklemur commented on GitHub (Aug 19, 2019):
Is there any documentation on that?
@max commented on GitHub (Aug 19, 2019):
https://help.github.com/en/articles/about-github-actions
@gep13 commented on GitHub (Aug 19, 2019):
Very happy to say that this is now up and running! Huge thanks to @max for his help on this!