Checks not working on all PR's #6

New Issue

2025-11-06T17:05:38-06:00

GiteaMirror commented

2025-11-06 17:05:38 -06:00

Originally created by @gep13 on GitHub (Mar 4, 2019).

For example, there are no checks on this PR:

https://github.com/sdras/awesome-actions/pull/97/checks

@sdras I am not able to see the settings of this repository, are you able to confirm how the settings are set up in this area? It would be good to have the awesome-lint action that @max added to this repository working on all PR's.

Originally created by @gep13 on GitHub (Mar 4, 2019). For example, there are no checks on this PR: https://github.com/sdras/awesome-actions/pull/97/checks @sdras I am not able to see the settings of this repository, are you able to confirm how the settings are set up in this area? It would be good to have the awesome-lint action that @max added to this repository working on all PR's.

GiteaMirror closed this issue

2025-11-06 17:05:38 -06:00

GiteaMirror commented

2025-11-06 17:05:39 -06:00

@xt0rted commented on GitHub (Mar 4, 2019):

I think the workflow needs to be changed from push to pull_request. Or a second workflow added for pull_request.

@xt0rted commented on GitHub (Mar 4, 2019): I think the workflow needs to be changed from `push` to `pull_request`. Or a second workflow added for `pull_request`.

GiteaMirror commented

2025-11-06 17:05:40 -06:00

@gep13 commented on GitHub (Mar 4, 2019):

@xt0rted I think you could be right! Thanks for posting here.

Would you mind creating a new PR on this repo to test this out? I have switched the workflow to trigger on pull_request.

@gep13 commented on GitHub (Mar 4, 2019): @xt0rted I think you could be right! Thanks for posting here. Would you mind creating a new PR on this repo to test this out? I have switched the workflow to trigger on `pull_request`.

GiteaMirror commented

2025-11-06 17:05:40 -06:00

@xt0rted commented on GitHub (Mar 4, 2019):

#99 I'm not seeing any checks yet though 😕

It worked in my fork https://github.com/xt0rted/awesome-actions/pull/2/checks

@xt0rted commented on GitHub (Mar 4, 2019): #99 I'm not seeing any checks yet though 😕 It worked in my fork https://github.com/xt0rted/awesome-actions/pull/2/checks

GiteaMirror commented

2025-11-06 17:05:41 -06:00

@gep13 commented on GitHub (Mar 4, 2019):

@xt0rted I am starting to think that there is a setting that is required to make this work, but not sure what...

I will reach out to someone who might be able to help.

@gep13 commented on GitHub (Mar 4, 2019): @xt0rted I am starting to think that there is a setting that is required to make this work, but not sure what... I will reach out to someone who might be able to help.

GiteaMirror commented

2025-11-06 17:05:41 -06:00

@gep13 commented on GitHub (Mar 4, 2019):

@xt0rted The checks also showed up correctly on a PR that I raised here:

https://github.com/sdras/awesome-actions/pull/96

This was before switching to pull_request as well.

@gep13 commented on GitHub (Mar 4, 2019): @xt0rted The checks also showed up correctly on a PR that I raised here: https://github.com/sdras/awesome-actions/pull/96 This was before switching to `pull_request` as well.

GiteaMirror commented

2025-11-06 17:05:42 -06:00

@xt0rted commented on GitHub (Mar 7, 2019):

I set up a new workflow yesterday and had everything running on pull_request but what I found was even updating a PR's labels triggered the actions to run. I think you were right having this run on push because when I changed it over to push it continued running for commits but not for other changes (labels, projects, etc.).

@xt0rted commented on GitHub (Mar 7, 2019): I set up a new workflow yesterday and had everything running on `pull_request` but what I found was even updating a PR's labels triggered the actions to run. I think you were right having this run on `push` because when I changed it over to `push` it continued running for commits but not for other changes (labels, projects, etc.).

GiteaMirror commented

2025-11-06 17:05:42 -06:00

@gep13 commented on GitHub (Mar 7, 2019):

@xt0rted while you are here... was this on a private repo you were testing? I seem to remember that there is a limitation on what works on a public repo while in the GitHub Actions beta.

@gep13 commented on GitHub (Mar 7, 2019): @xt0rted while you are here... was this on a private repo you were testing? I seem to remember that there is a limitation on what works on a public repo while in the GitHub Actions beta.

GiteaMirror commented

2025-11-06 17:05:43 -06:00

@gep13 commented on GitHub (Mar 7, 2019):

@xt0rted for now, I have switched back to the push event.

@gep13 commented on GitHub (Mar 7, 2019): @xt0rted for now, I have switched back to the push event.

GiteaMirror commented

2025-11-06 17:05:44 -06:00

@xt0rted commented on GitHub (Mar 7, 2019):

It was a private repo where they were running after changing the labels of a PR. It makes sense after looking at the api more, the pull_request event is fired for anything related to a PR.

According to https://developer.github.com/actions/creating-workflows/workflow-configuration-options/#pull-request-events-for-forked-repositories

If you intend to use the pull_request event to trigger CI tests, it's recommended to listen to the push event.

Also found https://developer.github.com/actions/changes/2018-12-18-limited-public-actions/

GitHub Actions can now be triggered on push events in public repositories by repository owners.

I'm not sure if this update changed any of that though https://developer.github.com/actions/changes/2019-01-29-public-actions-update/

@xt0rted commented on GitHub (Mar 7, 2019): It was a private repo where they were running after changing the labels of a PR. It makes sense after looking at the api more, the `pull_request` event is fired for anything related to a PR. According to https://developer.github.com/actions/creating-workflows/workflow-configuration-options/#pull-request-events-for-forked-repositories >If you intend to use the `pull_request` event to trigger CI tests, it's recommended to listen to the `push` event. Also found https://developer.github.com/actions/changes/2018-12-18-limited-public-actions/ >GitHub Actions can now be triggered on push events in public repositories _by repository owners._ I'm not sure if this update changed any of that though https://developer.github.com/actions/changes/2019-01-29-public-actions-update/

GiteaMirror commented

2025-11-06 17:05:44 -06:00

@gep13 commented on GitHub (Mar 7, 2019):

Hmm, very strange then. I will follow up directly with GitHub support, to see if I can get an answer.

@gep13 commented on GitHub (Mar 7, 2019): Hmm, very strange then. I will follow up directly with GitHub support, to see if I can get an answer.

GiteaMirror commented

2025-11-06 17:05:44 -06:00

@gep13 commented on GitHub (Mar 16, 2019):

@xt0rted I have heard back from GitHub support on this, seems like this is known issue 😢

I'm afraid check runs for Actions do not currently show on Pull Requests when it's between a parent and a fork. This is something the team would like to improve upon in the future.

Guess we will simply have to wait and see if/when this ships. This is a real shame. Seems like this is an obvious thing that should/needs to be supported.

@gep13 commented on GitHub (Mar 16, 2019): @xt0rted I have heard back from GitHub support on this, seems like this is known issue 😢 > I'm afraid check runs for Actions do not currently show on Pull Requests when it's between a parent and a fork. This is something the team would like to improve upon in the future. Guess we will simply have to wait and see if/when this ships. This is a real shame. Seems like this is an obvious thing that should/needs to be supported.

GiteaMirror commented

2025-11-06 17:05:44 -06:00

@gep13 commented on GitHub (Mar 16, 2019):

This does explain why the checks appeared on the PR that I created, as this from a PR from this repository, and not a fork.

@gep13 commented on GitHub (Mar 16, 2019): This does explain why the checks appeared on the PR that I created, as this from a PR from this repository, and not a fork.

GiteaMirror commented

2025-11-06 17:05:45 -06:00

@cryptiklemur commented on GitHub (Aug 19, 2019):

Oof. That is quite the deal breaker... What a bummer

@cryptiklemur commented on GitHub (Aug 19, 2019): Oof. That is quite the deal breaker... What a bummer

GiteaMirror commented

2025-11-06 17:05:45 -06:00

@gep13 commented on GitHub (Aug 19, 2019):

@aequasi I am actually curious if this now “just works” would you be willing to test this out by sending a PR into this repo?

@gep13 commented on GitHub (Aug 19, 2019): @aequasi I am actually curious if this now “just works” would you be willing to test this out by sending a PR into this repo?

GiteaMirror commented

2025-11-06 17:05:46 -06:00

@max commented on GitHub (Aug 19, 2019):

@gep13 This will not “just work”. We’ve recently launched an updated version of GitHub Actions that does enable this workflow. I can flag this repository in but it requires updating the configuration file – we have changed the format. I’m happy to send you all a PR...

@max commented on GitHub (Aug 19, 2019): @gep13 This will not “just work”. We’ve recently launched an updated version of GitHub Actions that does enable this workflow. I can flag this repository in but it requires updating the configuration file – we have changed the format. I’m happy to send you all a PR...

GiteaMirror commented

2025-11-06 17:05:46 -06:00