github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2803] [MERGED] [PM-1835] Add ForwardEmail alias to Username Generator #9958

New Issue
Closed
opened 2026-04-11 02:32:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:32:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2803
Author: @aj-rosado
Created: 9/28/2023
Status: ✅ Merged
Merged: 10/26/2023
Merged by: @aj-rosado

Base: master ← Head: tools/pm-1060/Add-new-forwarder-forwardemail

📝 Commits (5)

  • f8a4340 Add ForwardEmail alias to Username Generator
  • 25d7348 remove unnecessary initializer
  • 02d0473 Merge branch 'master' into tools/pm-1060/Add-new-forwarder-forwardemail
  • 3ff9d13 Corrected order of alias Generators
  • ba34e36 PM-4307 - Trigger ForwardEmailDomainName PropertyChanged after initialization

📊 Changes

8 files changed (+118 additions, -0 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPage.xaml (+9 -0)
📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+27 -0)
📝 src/App/Resources/AppResources.Designer.cs (+9 -0)
📝 src/App/Resources/AppResources.resx (+4 -0)
📝 src/Core/Enums/ForwardedEmailServiceType.cs (+2 -0)
📝 src/Core/Models/Domain/UsernameGenerationOptions.cs (+8 -0)
➕ src/Core/Services/EmailForwarders/ForwardEmailForwarder.cs (+52 -0)
📝 src/Core/Services/UsernameGenerationService.cs (+7 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add ForwardEmail alias option to Username Generator

Code changes

  • ** ForwardEmailForwarder.cs:** Added class that inherits from BaseForwarder implementing the logic for ForwardEmail
  • Added ForwardEmail options to existing UsernameGenerator files

Screenshots

iOS:
Username generator Forward Email iOS

Android:
Username generator Forward Email Android

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2803 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 10/26/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `tools/pm-1060/Add-new-forwarder-forwardemail` --- ### 📝 Commits (5) - [`f8a4340`](https://github.com/bitwarden/android/commit/f8a43409280f5f1c6d28b01ba1c0bca171b3c2dd) Add ForwardEmail alias to Username Generator - [`25d7348`](https://github.com/bitwarden/android/commit/25d7348ae217259f6c5dc8d567d0ef0fefb4ad22) remove unnecessary initializer - [`02d0473`](https://github.com/bitwarden/android/commit/02d0473696b77b177b7d52c734c2c6b92748fadf) Merge branch 'master' into tools/pm-1060/Add-new-forwarder-forwardemail - [`3ff9d13`](https://github.com/bitwarden/android/commit/3ff9d13bacb204524dddaaba307cb4fcc1bff077) Corrected order of alias Generators - [`ba34e36`](https://github.com/bitwarden/android/commit/ba34e3694908d91583945c9b7975efb8d6f74d79) PM-4307 - Trigger ForwardEmailDomainName PropertyChanged after initialization ### 📊 Changes **8 files changed** (+118 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+9 -0) 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+27 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+9 -0) 📝 `src/App/Resources/AppResources.resx` (+4 -0) 📝 `src/Core/Enums/ForwardedEmailServiceType.cs` (+2 -0) 📝 `src/Core/Models/Domain/UsernameGenerationOptions.cs` (+8 -0) ➕ `src/Core/Services/EmailForwarders/ForwardEmailForwarder.cs` (+52 -0) 📝 `src/Core/Services/UsernameGenerationService.cs` (+7 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Add ForwardEmail alias option to Username Generator ## Code changes * ** ForwardEmailForwarder.cs:** Added class that inherits from BaseForwarder implementing the logic for `ForwardEmail` * Added `ForwardEmail` options to existing UsernameGenerator files ## Screenshots **iOS:** <img width="314" alt="Username generator Forward Email iOS" src="https://github.com/bitwarden/mobile/assets/109146700/3c18ce84-e70e-43fa-8119-3c2bcf5aeaf7"> **Android:** <img width="314" alt="Username generator Forward Email Android" src="https://github.com/bitwarden/mobile/assets/109146700/c1af23a9-1c7d-4b61-b7ec-000df2dc1cb5"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:32:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9958
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?