github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #5567] [MERGED] PM-24090: Remove ChromeAutofill feature flag #99257

New Issue
Closed
opened 2026-05-31 02:32:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-31 02:32:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5567
Author: @david-livefront
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @david-livefront

Base: main ← Head: PM-24090-remove-chrome-autofill-flag

📝 Commits (1)

  • c1da032 PM-24090: Remove ChromeAutofill feature flag

📊 Changes

9 files changed (+6 additions, -102 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/AutofillModule.kt (+2 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerImpl.kt (+1 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+0 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+0 -2)
📝 app/src/main/res/values/strings_non_localized.xml (+0 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt (+1 -6)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerTest.kt (+2 -54)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+0 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+0 -2)

📄 Description

🎟️ Tracking

PM-24090

📔 Objective

This PR removes the android chrome autofill feature flag from the app.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5567 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-24090-remove-chrome-autofill-flag` --- ### 📝 Commits (1) - [`c1da032`](https://github.com/bitwarden/android/commit/c1da03270b58a7e07893d256312b214e462f3d51) PM-24090: Remove ChromeAutofill feature flag ### 📊 Changes **9 files changed** (+6 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/AutofillModule.kt` (+2 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerImpl.kt` (+1 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+0 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+0 -2) 📝 `app/src/main/res/values/strings_non_localized.xml` (+0 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt` (+1 -6) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerTest.kt` (+2 -54) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+0 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+0 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-24090](https://bitwarden.atlassian.net/browse/PM-24090) ## 📔 Objective This PR removes the android chrome autofill feature flag from the app. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-24090]: https://bitwarden.atlassian.net/browse/PM-24090?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-31 02:32:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#99257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?