github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2643] [MERGED] [PM-2408] Pending admin approval requests #9845

New Issue
Closed
opened 2026-04-11 02:30:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:30:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2643
Author: @andrebispo5
Created: 7/25/2023
Status: ✅ Merged
Merged: 7/27/2023
Merged by: @andrebispo5

Base: auth/pm-2293-tde-auth-requests ← Head: auth/pm-2408-admin-preapproved

📝 Commits (10+)

  • 43befce [PM-2408] Save PendingAdminAuthRequest to state
  • 7f10459 [PM-2408] Add logic to check pending auth requests before creating a new one.
  • adf3a9a [PM-2408] Remove active user params
  • de70f89 Merge branch 'auth/pm-2293-tde-auth-requests' into auth/pm-2408-admin-preapproved
  • 5afc687 [PM-2408] Fix bug where TDE MP unlock wasn't syncing and vault appeared empty
  • a9668ab [PM-2408] Add reconciledOptions
  • 4cf0ed4 [PM-2408] Set user key when login using master password
  • 91b6e25 [PM-2408] Generate Fingerprint phrase and PubKey locally to avoid MITM attacks
  • 74daea5 Merge branch 'auth/pm-2293-tde-auth-requests' into auth/pm-2408-admin-preapproved
  • cef7976 [PM-2408] PR fixes

📊 Changes

13 files changed (+149 additions, -28 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+3 -0)
📝 src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs (+67 -21)
📝 src/App/Pages/Accounts/TwoFactorPage.xaml.cs (+8 -0)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+26 -1)
📝 src/Core/Abstractions/IAuthService.cs (+4 -1)
📝 src/Core/Abstractions/IStateService.cs (+2 -0)
📝 src/Core/Constants.cs (+1 -0)
➕ src/Core/Models/Domain/PendingAdminAuthRequest.cs (+10 -0)
📝 src/Core/Services/AuthService.cs (+5 -3)
📝 src/Core/Services/StateService.cs (+20 -2)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+1 -0)
📝 src/iOS.Extension/LoadingViewController.cs (+1 -0)
📝 src/iOS.ShareExtension/LoadingViewController.cs (+1 -0)

📄 Description

Merge after https://github.com/bitwarden/mobile/pull/2642

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Reuse created admin requests when trying to approve a login with TDE Admin approval request.

Code changes

Store admin request id and private key to secure storage.
When opening the screen check for pending admin requests.
If there is a pending admin request populate the vm data with the saved request.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/36ed5b21-d56a-4378-9cfe-111d466b6c33

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2643 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 7/25/2023 **Status:** ✅ Merged **Merged:** 7/27/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `auth/pm-2293-tde-auth-requests` ← **Head:** `auth/pm-2408-admin-preapproved` --- ### 📝 Commits (10+) - [`43befce`](https://github.com/bitwarden/android/commit/43befced0621889be7744c1cc263a9edb5241cdb) [PM-2408] Save PendingAdminAuthRequest to state - [`7f10459`](https://github.com/bitwarden/android/commit/7f10459673456f467976c69709268b1864ff7ea2) [PM-2408] Add logic to check pending auth requests before creating a new one. - [`adf3a9a`](https://github.com/bitwarden/android/commit/adf3a9ad6f9ab3b70a719897da71ce774e83ad4b) [PM-2408] Remove active user params - [`de70f89`](https://github.com/bitwarden/android/commit/de70f897e6be3d8fda2eea3d370309105514630d) Merge branch 'auth/pm-2293-tde-auth-requests' into auth/pm-2408-admin-preapproved - [`5afc687`](https://github.com/bitwarden/android/commit/5afc687d8989846f2424038254b2ee3157baa619) [PM-2408] Fix bug where TDE MP unlock wasn't syncing and vault appeared empty - [`a9668ab`](https://github.com/bitwarden/android/commit/a9668abf15f618d6fccb105b62bb4e4bd0aa51ab) [PM-2408] Add reconciledOptions - [`4cf0ed4`](https://github.com/bitwarden/android/commit/4cf0ed4ec11281e988afc438ad601d7d268b6d95) [PM-2408] Set user key when login using master password - [`91b6e25`](https://github.com/bitwarden/android/commit/91b6e25e8d9ab5cb2bc161a0e3de49ff71948027) [PM-2408] Generate Fingerprint phrase and PubKey locally to avoid MITM attacks - [`74daea5`](https://github.com/bitwarden/android/commit/74daea5393ef3406268400868f7c6434d1f4a4ce) Merge branch 'auth/pm-2293-tde-auth-requests' into auth/pm-2408-admin-preapproved - [`cef7976`](https://github.com/bitwarden/android/commit/cef79769f6890d8f24f313fa12b9fd8bbf99cebd) [PM-2408] PR fixes ### 📊 Changes **13 files changed** (+149 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+3 -0) 📝 `src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs` (+67 -21) 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml.cs` (+8 -0) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+26 -1) 📝 `src/Core/Abstractions/IAuthService.cs` (+4 -1) 📝 `src/Core/Abstractions/IStateService.cs` (+2 -0) 📝 `src/Core/Constants.cs` (+1 -0) ➕ `src/Core/Models/Domain/PendingAdminAuthRequest.cs` (+10 -0) 📝 `src/Core/Services/AuthService.cs` (+5 -3) 📝 `src/Core/Services/StateService.cs` (+20 -2) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+1 -0) 📝 `src/iOS.Extension/LoadingViewController.cs` (+1 -0) 📝 `src/iOS.ShareExtension/LoadingViewController.cs` (+1 -0) </details> ### 📄 Description Merge after https://github.com/bitwarden/mobile/pull/2642 ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Reuse created admin requests when trying to approve a login with TDE Admin approval request. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Store admin request id and private key to secure storage. When opening the screen check for pending admin requests. If there is a pending admin request populate the vm data with the saved request. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/36ed5b21-d56a-4378-9cfe-111d466b6c33 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:30:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9845
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?