github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2583] [MERGED] [PM-2737] Adding AutomationIDs for Send page elements #9805

New Issue
Closed
opened 2026-04-11 02:29:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:29:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2583
Author: @ifernandezdiaz
Created: 6/23/2023
Status: ✅ Merged
Merged: 6/28/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-2737/automationIDs-for-send-page-elements

📝 Commits (9)

  • 6c971cc Adding AutomationIDs for Send page elements
  • 8ecca88 Merge branch 'master' into PM-2737/automationIDs-for-send-page-elements
  • 29132d7 Fixing some spaces
  • 13a0d55 Adding Matt's suggestion
  • 728099f Adding Fede's suggestion
  • 7ebe989 Merge branch 'master' into PM-2737/automationIDs-for-send-page-elements
  • 9b0f22d Removing unnecesarry breaks
  • d13e4d9 Merge branch 'PM-2737/automationIDs-for-send-page-elements' of github.com:bitwarden/mobile into PM-2737/automationIDs-for-send-page-elements
  • a784301 Merge branch 'master' into PM-2737/automationIDs-for-send-page-elements

📊 Changes

4 files changed (+92 additions, -34 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+60 -29)
📝 src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml (+8 -4)
📝 src/App/Pages/Send/SendGroupingsPage/SendGroupingsPageListItem.cs (+22 -0)
📝 src/App/Pages/Send/SendsPage.xaml (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • SendAddEditPage.xaml: Adding IDs for each Send element
  • SendGroupingsPage.xaml: Adding IDs for Send lists
  • SendGroupingsPageListItem.xaml: Adding a new variable to make AutomationIDs dynamic
  • SendsPage.xaml: Adding IDs for label displayed when send list is empty

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2583 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/23/2023 **Status:** ✅ Merged **Merged:** 6/28/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-2737/automationIDs-for-send-page-elements` --- ### 📝 Commits (9) - [`6c971cc`](https://github.com/bitwarden/android/commit/6c971cc772df84d2c3766e8b2857fd9c0e88c1b1) Adding AutomationIDs for Send page elements - [`8ecca88`](https://github.com/bitwarden/android/commit/8ecca8846db7b64c88bcd172a3f035f8f1755991) Merge branch 'master' into PM-2737/automationIDs-for-send-page-elements - [`29132d7`](https://github.com/bitwarden/android/commit/29132d7fba5bd6244b6eed7105102d184ee8b91c) Fixing some spaces - [`13a0d55`](https://github.com/bitwarden/android/commit/13a0d553fcadbe1e9ff4adad228f6cce634f50b6) Adding Matt's suggestion - [`728099f`](https://github.com/bitwarden/android/commit/728099fcc5770392563712daa11de828d7b0c77d) Adding Fede's suggestion - [`7ebe989`](https://github.com/bitwarden/android/commit/7ebe989522993f4861e5e1f0f9d79f594d376fe8) Merge branch 'master' into PM-2737/automationIDs-for-send-page-elements - [`9b0f22d`](https://github.com/bitwarden/android/commit/9b0f22d6ac43071c14cfe2b333ca83d9abedc9a7) Removing unnecesarry breaks - [`d13e4d9`](https://github.com/bitwarden/android/commit/d13e4d92149efe7a7c979cd43757d6fab056363e) Merge branch 'PM-2737/automationIDs-for-send-page-elements' of github.com:bitwarden/mobile into PM-2737/automationIDs-for-send-page-elements - [`a784301`](https://github.com/bitwarden/android/commit/a784301262860a26930c07ecda530ca893c1e201) Merge branch 'master' into PM-2737/automationIDs-for-send-page-elements ### 📊 Changes **4 files changed** (+92 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+60 -29) 📝 `src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml` (+8 -4) 📝 `src/App/Pages/Send/SendGroupingsPage/SendGroupingsPageListItem.cs` (+22 -0) 📝 `src/App/Pages/Send/SendsPage.xaml` (+2 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests ## Code changes * **SendAddEditPage.xaml:** Adding IDs for each Send element * **SendGroupingsPage.xaml:** Adding IDs for Send lists * **SendGroupingsPageListItem.xaml:** Adding a new variable to make AutomationIDs dynamic * **SendsPage.xaml:** Adding IDs for label displayed when send list is empty ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:29:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9805
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?