github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-18 22:47:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3106] [MERGED] [PM-6798] Fix account switch on autofill #97410

New Issue
Closed
opened 2026-05-30 22:17:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-30 22:17:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3106
Author: @fedemkr
Created: 3/22/2024
Status: ✅ Merged
Merged: 3/25/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: vault/pm-6798/fix-account-switch-on-autofill

📝 Commits (2)

  • dcd599f PM-6798 Force state update when opening the Autofill extension
  • 31f3e03 PM-6798 Fix InitAppIfNeededAsync to be awaited and also ignored Fido2AuthenticatorException from logging them to AppCenter since they don't add much information and we're logging in other places what we need

📊 Changes

4 files changed (+28 additions, -11 deletions)

View changed files

📝 src/Core/Abstractions/IStateService.cs (+1 -0)
📝 src/Core/Services/StateService.cs (+6 -1)
📝 src/iOS.Autofill/CredentialProviderViewController.Passkeys.cs (+6 -2)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+15 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix account switching to work correctly on autofill, loading the latest state of the accounts.

Code changes

  • StateService: Added way to force reloading the state
  • CredentialProviderViewController: Made InitAppIfNeededAsync async to be able to force reloading the state when loading the extension and also on the several callbacks for actions on the extension.
  • Others: Also, ignored Fido2AuthenticatorException from logging them into AppCenter given they don't add any valuable logging if an exception is raised, and if that happens we log the problem in a different part of the code.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3106 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/22/2024 **Status:** ✅ Merged **Merged:** 3/25/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6798/fix-account-switch-on-autofill` --- ### 📝 Commits (2) - [`dcd599f`](https://github.com/bitwarden/android/commit/dcd599f30012c2e4e5ec3bb30b39e88c9c818789) PM-6798 Force state update when opening the Autofill extension - [`31f3e03`](https://github.com/bitwarden/android/commit/31f3e033b23b82303b1105d54391e47b89e0ca46) PM-6798 Fix InitAppIfNeededAsync to be awaited and also ignored Fido2AuthenticatorException from logging them to AppCenter since they don't add much information and we're logging in other places what we need ### 📊 Changes **4 files changed** (+28 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IStateService.cs` (+1 -0) 📝 `src/Core/Services/StateService.cs` (+6 -1) 📝 `src/iOS.Autofill/CredentialProviderViewController.Passkeys.cs` (+6 -2) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+15 -8) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix account switching to work correctly on autofill, loading the latest state of the accounts. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **StateService:** Added way to force reloading the state * **CredentialProviderViewController:** Made `InitAppIfNeededAsync` async to be able to force reloading the state when loading the extension and also on the several callbacks for actions on the extension. * **Others:** Also, ignored `Fido2AuthenticatorException` from logging them into AppCenter given they don't add any valuable logging if an exception is raised, and if that happens we log the problem in a different part of the code. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-30 22:17:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#97410