github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2909] [MERGED] [PM-4584] Login with Device is sending a notification to the initiating device #97263

New Issue
Closed
opened 2026-05-30 21:54:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-30 21:54:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2909
Author: @andrebispo5
Created: 12/19/2023
Status: ✅ Merged
Merged: 1/2/2024
Merged by: @andrebispo5

Base: main ← Head: auth/pm-4584/notification-to-same-device

📝 Commits (2)

  • 628cfb1 [PM-4584] Add device identifier to request headers.
  • f27a353 Merge branch 'main' into auth/pm-4584/notification-to-same-device

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/Core/Services/ApiService.cs (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix bug when the user starts a login with device, the notification is appearing on the current device as well.

Code changes

Add "Device-Identifier" header so it can be excluded server side.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2909 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 1/2/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `auth/pm-4584/notification-to-same-device` --- ### 📝 Commits (2) - [`628cfb1`](https://github.com/bitwarden/android/commit/628cfb163441faf77f0a723fa9f52afc473b8e05) [PM-4584] Add device identifier to request headers. - [`f27a353`](https://github.com/bitwarden/android/commit/f27a353c389979c6c4b231d1e39cfc9888a9b3d2) Merge branch 'main' into auth/pm-4584/notification-to-same-device ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/ApiService.cs` (+2 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix bug when the user starts a login with device, the notification is appearing on the current device as well. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Add "Device-Identifier" header so it can be excluded server side. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-30 21:54:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#97263