github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 08:36:09 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1748] [MERGED] Usability: dismiss account list on certain events #96475

New Issue
Closed
opened 2026-05-30 20:01:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-30 20:01:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1748
Author: @mpbw2
Created: 2/2/2022
Status: ✅ Merged
Merged: 2/2/2022
Merged by: @mpbw2

Base: accountswitching ← Head: accountswitching-menu-hiding

📝 Commits (2)

  • 4a6353e dismiss account list on certain events
  • 6638b65 use new FireAndForget method for back button logic

📊 Changes

6 files changed (+68 additions, -4 deletions)

View changed files

📝 src/App/Pages/Accounts/HomePage.xaml.cs (+11 -0)
📝 src/App/Pages/Accounts/LockPage.xaml (+2 -2)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+13 -0)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+13 -0)
📝 src/App/Pages/BaseContentPage.cs (+5 -0)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+24 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Dismiss the account list on certain events, like selecting toolbar options that are still accessible when the menu is showing, the Android back button, etc.

Code changes

  • HomePage.xaml.cs: Hide account list when opening environment controls, and Android back button support
  • LockPage.xaml: Cleanup formatting to be identical to other pages with account switching overlay
  • LockPage.xaml.cs: Hide account list when selecting Log Out (Android) or when More is clicked (iOS), and Android back button support
  • LoginPage.xaml.cs: Hide account list in CloseAction, when More is clicked, and Android back button support
  • GroupingsPage.xaml.cs: Hide account list on Search, Sync, Lock, Exit, Add, and ShowPreviousPage. Added missing _fab arg in AccountSwitch_Clicked and AccountSwitchingOverlay_Tapped. Support for Android back button.
  • BaseContentPage.xaml.cs: Prevent animation flow from executing again if account list is already hidden

Testing requirements

Observe open account list behavior when tapping other elements on screen that are still accessible.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1748 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/2/2022 **Status:** ✅ Merged **Merged:** 2/2/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `accountswitching` ← **Head:** `accountswitching-menu-hiding` --- ### 📝 Commits (2) - [`4a6353e`](https://github.com/bitwarden/android/commit/4a6353ed2558881e78df6d04203200102a731ba4) dismiss account list on certain events - [`6638b65`](https://github.com/bitwarden/android/commit/6638b658d07808660111f4f39937128cb6d0da6b) use new FireAndForget method for back button logic ### 📊 Changes **6 files changed** (+68 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+11 -0) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+2 -2) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+13 -0) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+13 -0) 📝 `src/App/Pages/BaseContentPage.cs` (+5 -0) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+24 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Dismiss the account list on certain events, like selecting toolbar options that are still accessible when the menu is showing, the Android back button, etc. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **HomePage.xaml.cs:** Hide account list when opening environment controls, and Android back button support * **LockPage.xaml:** Cleanup formatting to be identical to other pages with account switching overlay * **LockPage.xaml.cs:** Hide account list when selecting Log Out (Android) or when More is clicked (iOS), and Android back button support * **LoginPage.xaml.cs:** Hide account list in CloseAction, when More is clicked, and Android back button support * **GroupingsPage.xaml.cs:** Hide account list on Search, Sync, Lock, Exit, Add, and ShowPreviousPage. Added missing _fab arg in `AccountSwitch_Clicked` and `AccountSwitchingOverlay_Tapped`. Support for Android back button. * **BaseContentPage.xaml.cs:** Prevent animation flow from executing again if account list is already hidden ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Observe open account list behavior when tapping other elements on screen that are still accessible. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-30 20:01:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#96475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?