github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2222] [MERGED] [SG-872] Create generic exception handler for mobile #9582

New Issue
Closed
opened 2026-04-11 02:24:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:24:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2222
Author: @andrebispo5
Created: 12/5/2022
Status: ✅ Merged
Merged: 12/13/2022
Merged by: @andrebispo5

Base: master ← Head: beeep/SG-872-generic-exception

📝 Commits (2)

  • 59b3458 [SG-872] Add method to handle exception in BaseViewModel
  • afadeb8 [SG-872] Code format

📊 Changes

3 files changed (+20 additions, -21 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+0 -10)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+0 -10)
📝 src/App/Pages/BaseViewModel.cs (+20 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We currently do not have generic error handling code in the mobile repo to handle errors and present them to the user in a consistent manner.

Code changes

Add method in BaseViewModel to handle exceptions this will show the user a dialog with a generic or custom message.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2222 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 12/5/2022 **Status:** ✅ Merged **Merged:** 12/13/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `beeep/SG-872-generic-exception` --- ### 📝 Commits (2) - [`59b3458`](https://github.com/bitwarden/android/commit/59b3458fe174e857464e50d56abcf52241820b7e) [SG-872] Add method to handle exception in BaseViewModel - [`afadeb8`](https://github.com/bitwarden/android/commit/afadeb8c2826f334b7b32642299e4d33a868f43b) [SG-872] Code format ### 📊 Changes **3 files changed** (+20 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+0 -10) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+0 -10) 📝 `src/App/Pages/BaseViewModel.cs` (+20 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> We currently do not have generic error handling code in the mobile repo to handle errors and present them to the user in a consistent manner. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Add method in BaseViewModel to handle exceptions this will show the user a dialog with a generic or custom message. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:24:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?