github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 22:08:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6980] fix: Drop redundant Stripe checkout confirmation on Upgrade Now #93605

New Issue
Open
opened 2026-05-27 12:51:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:51:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6980
Author: @SaintPatrck
Created: 5/26/2026
Status: 🔄 Open

Base: main ← Head: premium-upgrade/revert-redundant-stripe-checkout-dialog

📝 Commits (1)

  • 2718a6b fix: Drop redundant Stripe checkout confirmation on Upgrade Now

📊 Changes

2 files changed (+5 additions, -76 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt (+1 -20)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt (+4 -56)

📄 Description

🎟️ Tracking

Follow-up to #6958.

📔 Objective

The Upgrade Now CTA on the free Premium plan screen already shows the Stripe checkout disclosure directly beneath the button. The confirmation dialog added in #6958 repeated that exact copy verbatim, costing an extra tap without conveying any new information.

This change removes the dialog so the footer is the single, in-context disclosure for that CTA. The Cancel Premium and Manage Plan confirmation dialogs are unaffected; neither has accompanying footer copy, so their dialogs still earn their place.

📸 Screenshots

Not applicable — visible UI is unchanged. The Upgrade Now button now navigates directly to Stripe, matching the behavior described by the footer copy already on screen.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6980 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/26/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `premium-upgrade/revert-redundant-stripe-checkout-dialog` --- ### 📝 Commits (1) - [`2718a6b`](https://github.com/bitwarden/android/commit/2718a6b748bf364134a9474d8568bd25b996101f) fix: Drop redundant Stripe checkout confirmation on Upgrade Now ### 📊 Changes **2 files changed** (+5 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreen.kt` (+1 -20) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/premium/plan/PlanScreenTest.kt` (+4 -56) </details> ### 📄 Description ## 🎟️ Tracking Follow-up to #6958. ## 📔 Objective The Upgrade Now CTA on the free Premium plan screen already shows the Stripe checkout disclosure directly beneath the button. The confirmation dialog added in #6958 repeated that exact copy verbatim, costing an extra tap without conveying any new information. This change removes the dialog so the footer is the single, in-context disclosure for that CTA. The Cancel Premium and Manage Plan confirmation dialogs are unaffected; neither has accompanying footer copy, so their dialogs still earn their place. ## 📸 Screenshots Not applicable — visible UI is unchanged. The Upgrade Now button now navigates directly to Stripe, matching the behavior described by the footer copy already on screen. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:51:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93605