github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 20:47:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6869] [MERGED] [BWA-253] bug: Filtering empty otp uris sent by Password Manager app #93512

New Issue
Closed
opened 2026-05-27 12:38:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:38:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6869
Author: @aj-rosado
Created: 5/4/2026
Status: ✅ Merged
Merged: 5/6/2026
Merged by: @aj-rosado

Base: main ← Head: BWA-253/not-displaying-totp-coded-with-empty-key

📝 Commits (2)

  • cff6bd8 Filtering empty otp uris from PM app
  • 1d64e70 Added test to verify if getTotpCodesFlow is properly called

📊 Changes

2 files changed (+43 additions, -3 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryImpl.kt (+8 -2)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryTest.kt (+35 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-253

📔 Objective

Authenticator app should not display TOTP items that have an empty uri/key. This aims to filter the empty ones out

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6869 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 5/4/2026 **Status:** ✅ Merged **Merged:** 5/6/2026 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `BWA-253/not-displaying-totp-coded-with-empty-key` --- ### 📝 Commits (2) - [`cff6bd8`](https://github.com/bitwarden/android/commit/cff6bd82bdc7cc715238fc238bd438d9be31246f) Filtering empty otp uris from PM app - [`1d64e70`](https://github.com/bitwarden/android/commit/1d64e709f672347d797cbb2899c73abdd7623caa) Added test to verify if getTotpCodesFlow is properly called ### 📊 Changes **2 files changed** (+43 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryImpl.kt` (+8 -2) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryTest.kt` (+35 -1) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/BWA-253 ## 📔 Objective Authenticator app should not display TOTP items that have an empty uri/key. This aims to filter the empty ones out --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:38:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93512
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?