github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-18 14:41:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6805] [MERGED] PM-35273: feat: Add support for SDK API calls by providing base urls #93457

New Issue
Closed
opened 2026-05-27 12:32:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:32:24 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6805
Author: @david-livefront
Created: 4/16/2026
Status: ✅ Merged
Merged: 4/20/2026
Merged by: @david-livefront

Base: main ← Head: update-sdk-client-settings

📝 Commits (1)

  • e34f30d Add support for SDK API calls by providing base urls

📊 Changes

17 files changed (+270 additions, -75 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt (+24 -29)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt (+21 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/sdk/BaseSdkSource.kt (+14 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManager.kt (+14 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerImpl.kt (+17 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactory.kt (+10 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt (+17 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepository.kt (+2 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceImpl.kt (+6 -6)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt (+30 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerTest.kt (+12 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryTests.kt (+70 -3)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepositoryTest.kt (+13 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceTest.kt (+3 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt (+13 -5)
📝 network/src/main/kotlin/com/bitwarden/network/model/BitwardenServiceClientConfig.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-35273

📔 Objective

This PR adds support for instantiating the Bitwarden SDK Client with ClientSettings allowing the SDK to make appropriate network requests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6805 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/16/2026 **Status:** ✅ Merged **Merged:** 4/20/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-sdk-client-settings` --- ### 📝 Commits (1) - [`e34f30d`](https://github.com/bitwarden/android/commit/e34f30de8579555cab9c98a46acaa1c4bb8909c4) Add support for SDK API calls by providing base urls ### 📊 Changes **17 files changed** (+270 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt` (+24 -29) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+21 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/sdk/BaseSdkSource.kt` (+14 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManager.kt` (+14 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerImpl.kt` (+17 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactory.kt` (+10 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt` (+17 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepository.kt` (+2 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceImpl.kt` (+6 -6) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt` (+30 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerTest.kt` (+12 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryTests.kt` (+70 -3) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepositoryTest.kt` (+13 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/datasource/sdk/GeneratorSdkSourceTest.kt` (+3 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+13 -5) 📝 `network/src/main/kotlin/com/bitwarden/network/model/BitwardenServiceClientConfig.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-35273](https://bitwarden.atlassian.net/browse/PM-35273) ## 📔 Objective This PR adds support for instantiating the Bitwarden SDK Client with `ClientSettings` allowing the SDK to make appropriate network requests. [PM-35273]: https://bitwarden.atlassian.net/browse/PM-35273?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:32:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93457