github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6742] [MERGED] PM-34231: feat: Support renaming attachments during creation #93414

New Issue
Closed
opened 2026-05-27 12:26:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:26:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6742
Author: @david-livefront
Created: 3/30/2026
Status: ✅ Merged
Merged: 3/31/2026
Merged by: @david-livefront

Base: main ← Head: PM-34231-rename-attachments

📝 Commits (1)

  • 70ce8e8 PM-34231: Support renaming attachments during creation

📊 Changes

8 files changed (+386 additions, -10 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt (+140 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsScreen.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsViewModel.kt (+61 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt (+4 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsScreenTest.kt (+25 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsViewModelTest.kt (+76 -5)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/NonEditableExtensionVisualTransformation.kt (+78 -0)
📝 ui/src/main/res/values/strings.xml (+1 -0)

📄 Description

🎟️ Tracking

PM-34231

📔 Objective

This PR adds the ability to update attachment names when creating them.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6742 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/30/2026 **Status:** ✅ Merged **Merged:** 3/31/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-34231-rename-attachments` --- ### 📝 Commits (1) - [`70ce8e8`](https://github.com/bitwarden/android/commit/70ce8e8c50e7c671b403d118b719be1ae929817d) PM-34231: Support renaming attachments during creation ### 📊 Changes **8 files changed** (+386 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt` (+140 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsScreen.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsViewModel.kt` (+61 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt` (+4 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsScreenTest.kt` (+25 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsViewModelTest.kt` (+76 -5) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/NonEditableExtensionVisualTransformation.kt` (+78 -0) 📝 `ui/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-34231](https://bitwarden.atlassian.net/browse/PM-34231) ## 📔 Objective This PR adds the ability to update attachment names when creating them. ## 📸 Screenshots | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/0c4d14bd-cf32-4ffc-ae3f-467a597b5214" width="350"/> | <video src="https://github.com/user-attachments/assets/91a83d3c-028f-48c5-afe3-df78cb016865" width="350" /> | [PM-34231]: https://bitwarden.atlassian.net/browse/PM-34231?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:26:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93414
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?