github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-14 23:51:04 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6689] [MERGED] misc: Rename the VaultDiskSource Flows #93366

New Issue
Closed
opened 2026-05-27 12:20:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:20:07 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6689
Author: @david-livefront
Created: 3/18/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @david-livefront

Base: main ← Head: rename-disk-source-flows

📝 Commits (1)

  • ee4780c Rename the VaultDiskSource Flows

📊 Changes

21 files changed (+77 additions, -71 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSource.kt (+10 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt (+11 -11)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/CollectionsDao.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FoldersDao.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/SendsDao.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/FolderManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerImpl.kt (+4 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceTest.kt (+8 -8)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeCollectionsDao.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeDomainsDao.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeFoldersDao.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeSendsDao.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt (+2 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/FolderManagerTest.kt (+7 -7)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerTest.kt (+16 -10)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerTest.kt (+4 -4)

...and 1 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR updates the function names that return a flow in the VaultDiskSource to include the word Flow. This will be useful as we add new functions that retrieve similar data as a suspending call instead of a Flow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6689 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/18/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `rename-disk-source-flows` --- ### 📝 Commits (1) - [`ee4780c`](https://github.com/bitwarden/android/commit/ee4780c1f26f4e57733e6e4a3228a41826470fd0) Rename the VaultDiskSource Flows ### 📊 Changes **21 files changed** (+77 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSource.kt` (+10 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt` (+11 -11) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/CollectionsDao.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FoldersDao.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/SendsDao.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/FolderManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerImpl.kt` (+4 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceTest.kt` (+8 -8) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeCollectionsDao.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeDomainsDao.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeFoldersDao.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeSendsDao.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt` (+2 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/FolderManagerTest.kt` (+7 -7) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/SendManagerTest.kt` (+16 -10) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultSyncManagerTest.kt` (+4 -4) _...and 1 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR updates the function names that return a flow in the `VaultDiskSource` to include the word `Flow`. This will be useful as we add new functions that retrieve similar data as a suspending call instead of a Flow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:20:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93366