github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-14 23:51:04 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6676] [MERGED] [PM-33553] fix: Remove "Why am I seeing this?" link from cookie sync screen #93353

New Issue
Closed
opened 2026-05-27 12:18:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:18:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6676
Author: @SaintPatrck
Created: 3/16/2026
Status: ✅ Merged
Merged: 3/17/2026
Merged by: @SaintPatrck

Base: main ← Head: PM-33553/remove-why-am-i-seeing-this

📝 Commits (1)

  • 2168d1e [PM-33553] fix: Remove "Why am I seeing this?" link from cookie acquisition screen

📊 Changes

5 files changed (+0 additions, -78 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionScreen.kt (+0 -18)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionViewModel.kt (+0 -16)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/handlers/CookieAcquisitionHandler.kt (+0 -6)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionScreenTest.kt (+0 -24)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionViewModelTest.kt (+0 -14)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33553

📔 Objective

Remove the "Why am I seeing this?" text button and link from the "Sync with browser" (cookie acquisition) screen.

The link currently directs users to a generic help page (bitwarden.com/help) that provides no relevant information about the cookie sync feature. The docs team confirmed there is no appropriate destination for this link, so it is removed entirely per PM-33553.

Changes:

  • Removed WhyAmISeeingThisClick action, NavigateToHelp event, and HELP_URL constant from CookieAcquisitionViewModel
  • Removed onWhyAmISeeingThisClick handler from CookieAcquisitionHandler
  • Removed BitwardenTextButton and NavigateToHelp event handling from CookieAcquisitionScreen
  • Removed corresponding test cases from ViewModel and Screen tests

Note: The why_am_i_seeing_this string resource is retained as it is still used by MigrateToMyItemsScreen.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6676 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/16/2026 **Status:** ✅ Merged **Merged:** 3/17/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-33553/remove-why-am-i-seeing-this` --- ### 📝 Commits (1) - [`2168d1e`](https://github.com/bitwarden/android/commit/2168d1ecb5317272d8a390cf2e2909009534232c) [PM-33553] fix: Remove "Why am I seeing this?" link from cookie acquisition screen ### 📊 Changes **5 files changed** (+0 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionScreen.kt` (+0 -18) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionViewModel.kt` (+0 -16) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/handlers/CookieAcquisitionHandler.kt` (+0 -6) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionScreenTest.kt` (+0 -24) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/cookieacquisition/CookieAcquisitionViewModelTest.kt` (+0 -14) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-33553 ## 📔 Objective Remove the "Why am I seeing this?" text button and link from the "Sync with browser" (cookie acquisition) screen. The link currently directs users to a generic help page (`bitwarden.com/help`) that provides no relevant information about the cookie sync feature. The docs team confirmed there is no appropriate destination for this link, so it is removed entirely per PM-33553. **Changes:** - Removed `WhyAmISeeingThisClick` action, `NavigateToHelp` event, and `HELP_URL` constant from `CookieAcquisitionViewModel` - Removed `onWhyAmISeeingThisClick` handler from `CookieAcquisitionHandler` - Removed `BitwardenTextButton` and `NavigateToHelp` event handling from `CookieAcquisitionScreen` - Removed corresponding test cases from ViewModel and Screen tests Note: The `why_am_i_seeing_this` string resource is retained as it is still used by `MigrateToMyItemsScreen`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:18:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93353