github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6641] [MERGED] PM-33428: bug: Fix loading dialog statusbar content color #93320

New Issue
Closed
opened 2026-05-27 12:14:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 12:14:07 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6641
Author: @david-livefront
Created: 3/11/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @david-livefront

Base: main ← Head: PM-33428-loading-statusbar-content

📝 Commits (1)

  • a51db1b Fix loading dialog statusbar content color

📊 Changes

6 files changed (+15 additions, -5 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt (+1 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt (+1 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/base/util/StatusBarsAppearanceAffect.kt (+7 -3)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/BitwardenLoadingDialog.kt (+2 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/color/BitwardenColorScheme.kt (+1 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/theme/color/ColorScheme.kt (+3 -0)

📄 Description

🎟️ Tracking

PM-33428

📔 Objective

This PR updates the StatusBarsAppearanceAffect to function from within a dialog and then uses it to ensure the statusbar content using the correct colors when the BitwardenLoadingDialog is being displayed.

📸 Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6641 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/11/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-33428-loading-statusbar-content` --- ### 📝 Commits (1) - [`a51db1b`](https://github.com/bitwarden/android/commit/a51db1b34a29be3a6f2163baef6e0ad4e3e5b178) Fix loading dialog statusbar content color ### 📊 Changes **6 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt` (+1 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt` (+1 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/base/util/StatusBarsAppearanceAffect.kt` (+7 -3) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/BitwardenLoadingDialog.kt` (+2 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/color/BitwardenColorScheme.kt` (+1 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/theme/color/ColorScheme.kt` (+3 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-33428](https://bitwarden.atlassian.net/browse/PM-33428) ## 📔 Objective This PR updates the `StatusBarsAppearanceAffect` to function from within a dialog and then uses it to ensure the statusbar content using the correct colors when the `BitwardenLoadingDialog` is being displayed. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/c29a1bb3-8597-4e94-b942-4fffa670ee94" /> | <img width="350" src="https://github.com/user-attachments/assets/595fc3a1-95da-4abe-8ea9-d0a0e6c501f6" /> | [PM-33428]: https://bitwarden.atlassian.net/browse/PM-33428?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 12:14:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93320