github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 19:04:56 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6506] [MERGED] [PM-31993] Add deep link utilities for cookie vendor callbacks #93205

New Issue
Closed
opened 2026-05-27 11:57:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-27 11:57:07 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6506
Author: @SaintPatrck
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @SaintPatrck

Base: main ← Head: cookie-vending/p3-t5_deep-link-utils

📝 Commits (2)

  • 18e0eb7 [PM-31993] Add deep link utilities for cookie vendor callbacks
  • 7e44593 Refactor: Migrate CookieUtilsTest from JUnit 4 to JUnit 5

📊 Changes

2 files changed (+230 additions, -0 deletions)

View changed files

➕ app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/CookieUtils.kt (+60 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/CookieUtilsTest.kt (+170 -0)

📄 Description

🎟️ Tracking

PM-31993

📔 Objective

Implements Intent extension function to extract cookie callback results from
deep links. Supports both single and sharded cookie formats.

Implementation details:

  • Intent.getCookieCallbackResultOrNull() validates ACTION_VIEW, scheme, and host
  • Filters out 'd' completeness marker parameter from cookie extraction
  • Returns sealed CookieCallbackResult (MissingCookie | Success) with Parcelable support
  • Follows established patterns from SsoUtils, DuoUtils, and WebAuthUtils

Test coverage:

  • All guard clauses (action, data, scheme, host)
  • Single and sharded cookie parsing
  • Completeness marker filtering
  • Empty/null value handling
  • Multiple cookie support

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6506 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `cookie-vending/p3-t5_deep-link-utils` --- ### 📝 Commits (2) - [`18e0eb7`](https://github.com/bitwarden/android/commit/18e0eb7a21dc34d0a159312b0d8ba4930eb9a323) [PM-31993] Add deep link utilities for cookie vendor callbacks - [`7e44593`](https://github.com/bitwarden/android/commit/7e44593255bbdab2412c137c368a5f48f051d3f9) Refactor: Migrate CookieUtilsTest from JUnit 4 to JUnit 5 ### 📊 Changes **2 files changed** (+230 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/CookieUtils.kt` (+60 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/CookieUtilsTest.kt` (+170 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-31993 ## 📔 Objective Implements Intent extension function to extract cookie callback results from deep links. Supports both single and sharded cookie formats. Implementation details: - Intent.getCookieCallbackResultOrNull() validates ACTION_VIEW, scheme, and host - Filters out 'd' completeness marker parameter from cookie extraction - Returns sealed CookieCallbackResult (MissingCookie | Success) with Parcelable support - Follows established patterns from SsoUtils, DuoUtils, and WebAuthUtils Test coverage: - All guard clauses (action, data, scheme, host) - Single and sharded cookie parsing - Completeness marker filtering - Empty/null value handling - Multiple cookie support ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-27 11:57:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#93205