github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 13:07:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1811] [MERGED] Apply Disable Favicon setting globally to match desktop #9290

New Issue
Closed
opened 2026-04-11 02:17:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:17:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1811
Author: @mpbw2
Created: 2/24/2022
Status: ✅ Merged
Merged: 2/24/2022
Merged by: @mpbw2

Base: master ← Head: apply-iconsetting-globally

📝 Commits (2)

  • 92cf2c3 Apply Disable Favicon setting globally to match desktop
  • 30463ba streamline the approach to applying global settings

📊 Changes

3 files changed (+24 additions, -21 deletions)

View changed files

📝 src/App/Pages/Settings/OptionsPageViewModel.cs (+0 -1)
📝 src/Core/Abstractions/IStateService.cs (+0 -1)
📝 src/Core/Services/StateService.cs (+24 -19)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Make the "Disable Website Icons" option global to match desktop. I'm continuing to follow the Apply*Globally pattern established with the Theme change so a single block of code can be removed to restore per-account functionality in the future.

Code changes

  • StateService.cs: Created SetValueGloballyAsync method to support key/value based settings (values not in the Account object)
  • OptionsPageViewModel.cs: Removed previous Apply*Global calls since everything is contained within StateService now

Testing requirements

https://app.asana.com/0/1201803072708593/1201880420113232

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1811 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/24/2022 **Status:** ✅ Merged **Merged:** 2/24/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `apply-iconsetting-globally` --- ### 📝 Commits (2) - [`92cf2c3`](https://github.com/bitwarden/android/commit/92cf2c3894472c2c63111a2740602b27715228c6) Apply Disable Favicon setting globally to match desktop - [`30463ba`](https://github.com/bitwarden/android/commit/30463ba1147e9245f35c638b2eb99c19becc8d59) streamline the approach to applying global settings ### 📊 Changes **3 files changed** (+24 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/OptionsPageViewModel.cs` (+0 -1) 📝 `src/Core/Abstractions/IStateService.cs` (+0 -1) 📝 `src/Core/Services/StateService.cs` (+24 -19) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Make the "Disable Website Icons" option global to match desktop. I'm continuing to follow the `Apply*Globally` pattern established with the Theme change so a single block of code can be removed to restore per-account functionality in the future. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **StateService.cs:** Created `SetValueGloballyAsync` method to support key/value based settings (values not in the `Account` object) * **OptionsPageViewModel.cs:** Removed previous `Apply*Global` calls since everything is contained within `StateService` now ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> https://app.asana.com/0/1201803072708593/1201880420113232 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:17:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#9290